#7472 Thread view counts shouldn't trigger add_artifact tasks

v1.2.0
closed
General
2015-08-20
2014-06-17
No

The ThreadController.index method increases the view count of the thread. While it does set skip_mod_date, it still makes the thread object "dirty" (in the ming odm session), and thus ManagedSessionExtension/ArtifactSessionExtension thinks it is a change needing to be saved into solr, so and add_artifacts task runs. That is a lot of unnecessary work generated from a pageview. We shouldn't run the add_artifacts task (if not easy to avoid it, perhaps easier to run a mongo $inc command and avoid the session). And possibly consider not tracking view counts at all.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-08-15
    • labels: performance --> performance, 42cc
    • status: open --> in-progress
    • assigned_to: Igor Bondarenko
     
  • Igor Bondarenko

    Igor Bondarenko - 2014-08-21
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2014-08-21

    Closed #633. je/42cc_7472

     
  • Dave Brondsema

    Dave Brondsema - 2014-08-25
    • status: code-review --> closed
    • QA: Dave Brondsema
    • Milestone: forge-backlog --> forge-sep-5
     
  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.