The verify_addr method redirects to "/"; it'd be more useful to go to "/auth/preferences"
verify_addr
On branch db/7523 (and also some SF internal changes on forge-classic:db/7523)
I also added a flash notification upon submitting an email address, and a config option to prevent deleting your last verified address.
You still can delete last verified email if it is not primary.
Hm, checking code one more time I see that a new primary should be set when you delete the old one, but it does not work for me somehow...
Logs:
08:12:25,863 WARNI [forgesf.sf_providers] "None" was given for a preferred email address for admin1, selecting qwe@qwe.com instead
but qwe@qwe.com is the address I've deleted. Seems like select_new_primary_addrin sf provider returns deleted address somehow.
qwe@qwe.com
select_new_primary_addr
It duplicates only when your primary address is the first address in the addresses list. Maybe add a test for this case along with the fix?
You need user_prefs_storage.method = sf in production.ini to reproduce.Local storage method works fine.
user_prefs_storage.method = sf
production.ini
Fixed on forge-classic:db/7523 for deleting primary addr when it is listed first, with a test
And rebased both branches to get some recent adjacent verification mail changes incorporated and test updated.
Nice
Log in to post a comment.
On branch db/7523 (and also some SF internal changes on forge-classic:db/7523)
I also added a flash notification upon submitting an email address, and a config option to prevent deleting your last verified address.
You still can delete last verified email if it is not primary.
Hm, checking code one more time I see that a new primary should be set when you delete the old one, but it does not work for me somehow...
Logs:
but
qwe@qwe.comis the address I've deleted. Seems likeselect_new_primary_addrin sf provider returns deleted address somehow.It duplicates only when your primary address is the first address in the addresses list. Maybe add a test for this case along with the fix?
You need
user_prefs_storage.method = sfinproduction.inito reproduce.Local storage method works fine.Fixed on forge-classic:db/7523 for deleting primary addr when it is listed first, with a test
And rebased both branches to get some recent adjacent verification mail changes incorporated and test updated.
Nice