#7523 Better to go to /auth/preferences after email addr verification

v1.2.0
closed
General
2015-08-20
2014-07-02
No

The verify_addr method redirects to "/"; it'd be more useful to go to "/auth/preferences"

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-07-02
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
    • Size: --> 1
    • Milestone: forge-jul-25 --> forge-jul-11
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-02

    On branch db/7523 (and also some SF internal changes on forge-classic:db/7523)

    I also added a flash notification upon submitting an email address, and a config option to prevent deleting your last verified address.

     
  • Dave Brondsema

    Dave Brondsema - 2014-07-02
    • status: in-progress --> code-review
    • Size: 1 --> 2
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-11
    • Milestone: forge-jul-11 --> forge-jul-25
     
  • Igor Bondarenko

    Igor Bondarenko - 2014-07-17
    • QA: Igor Bondarenko
     
  • Igor Bondarenko

    Igor Bondarenko - 2014-07-17

    You still can delete last verified email if it is not primary.

    • add two email addresses and verify both
    • set the first one as primary
    • delete first one (works, since you have second verified address)
    • delete second one (works, but it should not, since it is last verified address)

    Hm, checking code one more time I see that a new primary should be set when you delete the old one, but it does not work for me somehow...

    Logs:

    08:12:25,863 WARNI [forgesf.sf_providers] "None" was given for a preferred email address for admin1, selecting qwe@qwe.com instead
    

    but qwe@qwe.com is the address I've deleted. Seems like select_new_primary_addrin sf provider returns deleted address somehow.

    It duplicates only when your primary address is the first address in the addresses list. Maybe add a test for this case along with the fix?

    You need user_prefs_storage.method = sf in production.ini to reproduce.Local storage method works fine.

     
  • Igor Bondarenko

    Igor Bondarenko - 2014-07-17
    • status: code-review --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-18
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-18

    Fixed on forge-classic:db/7523 for deleting primary addr when it is listed first, with a test

     
  • Dave Brondsema

    Dave Brondsema - 2014-07-18

    And rebased both branches to get some recent adjacent verification mail changes incorporated and test updated.

     
  • Igor Bondarenko

    Igor Bondarenko - 2014-07-21

    Nice

     
  • Igor Bondarenko

    Igor Bondarenko - 2014-07-21
    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.