The site_name config var should used instead of using SourceForge name. And I probably wouldn't use the brackets, we don't other places site_name is in a subject
The to header comes through as To: I[u'foo@asdfasdf.com'] (FYI the "I" is because it's a ming instrumented list)
you included some pydevd debugging lines
Once I realized the To: address needs to be explicitly set, I grepped for other cases where we send individual mail and don't specify a "To". Can you update these too?
Allura/allura/tasks/export_tasks.py
Allura/allura/controllers/auth.py
I wonder if sendsimplemail() is better suited for individual mails like these? I haven't looked closely but it has just a single param for to/destinations. which is nice.
If you feel inclined to add docstrings to things like the sendmail functions, feel free :) I think it'd be good to add documentation to things like that where parameter usage (e.g. default "To" value) isn't obvious. We use rst formatting for docstrings.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
al/7526
site_nameconfig var should used instead of using SourceForge name. And I probably wouldn't use the brackets, we don't other places site_name is in a subjectTo: I[u'foo@asdfasdf.com'](FYI the "I" is because it's a ming instrumented list)sendsimplemail()is better suited for individual mails like these? I haven't looked closely but it has just a single param for to/destinations. which is nice.sendsimplemail works perfectly for this use case