#7526 Fix mail headers in email verification email

v1.2.0
closed
General
2015-08-20
2014-07-02
No

In send_verification_link we should set headers better:

  • The To: header is missing
  • From: should be g.noreply (omit Reply-To header, or set the same)
  • Subject: should include the site name

Related

Tickets: #7579

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-07-11
    • Size: --> 1
     
  • Alexander Luberg

    • status: open --> in-progress
    • assigned_to: Alexander Luberg
     
  • Alexander Luberg

    • status: in-progress --> code-review
     
  • Alexander Luberg

    al/7526

     
  • Dave Brondsema

    Dave Brondsema - 2014-07-16
    • status: code-review --> in-progress
    • QA: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-16
    • The site_name config var should used instead of using SourceForge name. And I probably wouldn't use the brackets, we don't other places site_name is in a subject
    • The to header comes through as To: I[u'foo@asdfasdf.com'] (FYI the "I" is because it's a ming instrumented list)
    • you included some pydevd debugging lines
    • Once I realized the To: address needs to be explicitly set, I grepped for other cases where we send individual mail and don't specify a "To". Can you update these too?
      • Allura/allura/tasks/export_tasks.py
      • Allura/allura/controllers/auth.py
    • I wonder if sendsimplemail() is better suited for individual mails like these? I haven't looked closely but it has just a single param for to/destinations. which is nice.
    • If you feel inclined to add docstrings to things like the sendmail functions, feel free :) I think it'd be good to add documentation to things like that where parameter usage (e.g. default "To" value) isn't obvious. We use rst formatting for docstrings.
     
  • Alexander Luberg

    sendsimplemail works perfectly for this use case

     
  • Alexander Luberg

    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-18
    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.