#7538 If diff is empty, it shouldn't show "empty file" [ss7532]

v1.3.2
closed
General
2015-09-02
2014-07-05
Chris Tsai
No

[forge:site-support:#7352]

In this revision
https://sourceforge.net/p/kaldi/code/3889/
there were some property changes on files, but this is displayed by your site in a misleading way. It says
changed /trunk/egs/wsj/s5/steps/nnet2/dump_bottleneck_features.sh
changed /trunk/egs/wsj/s5/steps/nnet2/train_tanh_bottleneck.sh
and then later on, it says

/trunk/egs/wsj/s5/steps/nnet2/dump_bottleneck_features.sh Diff Switch to side-by-side view
Empty file
/trunk/egs/wsj/s5/steps/nnet2/train_tanh_bottleneck.sh Diff Switch to side-by-side view
Empty file

This looks like the user deleted the file, but what really happened is that they changed the svn:executable property to have a value ('').

Seems to me that the problem is the text used when the diff returns empty. Perhaps changing to "File contents unchanged" would work.

Discussion

  • Igor Bondarenko

    Igor Bondarenko - 2015-08-18
    • Owner: Anonymous --> Igor Bondarenko
    • Labels: support, p3, bitesize --> p3, support, 42cc, bitesize
    • Status: open --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2015-08-31
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2015-09-02
    • status: review --> closed
    • Reviewer: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2015-12-08
    • Milestone: unreleased --> v1.3.2
     

Log in to post a comment.