Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, deshani, dill0wn, and 10 others

#7692 claim_address() can skip its flush call

Milestone: v1.2.0

Status: closed

Owner: Dave Brondsema

Labels: None

Component: General

Reviewer: Igor Bondarenko

Updated: 2015-08-20

Created: 2014-09-18

Creator: Dave Brondsema

Private: No

claim_address() can skip the flush call if addr in self.email_addresses, but it should flush the main email record all the time.

I'm not aware of any problems this causes for Allura proper, but 3rd-party plugins that use the claim_address() method can suffer from this inconsistency.

Discussion

Dave Brondsema - 2014-09-18

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2014-09-18

db/7692

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Igor Bondarenko - 2014-09-19

QA: Igor Bondarenko
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Igor Bondarenko - 2014-09-19

status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-01-05

Milestone: unreleased --> asf_release_1.2.0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Apache Allura™

Forge software for hosting software projects

Milestone

Searches

Help

#7692 claim_address() can skip its flush call

Discussion