#7692 claim_address() can skip its flush call

v1.2.0
closed
None
General
2015-08-20
2014-09-18
No

claim_address() can skip the flush call if addr in self.email_addresses, but it should flush the main email record all the time.

I'm not aware of any problems this causes for Allura proper, but 3rd-party plugins that use the claim_address() method can suffer from this inconsistency.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-09-18
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2014-09-18

    db/7692

     
  • Igor Bondarenko

    Igor Bondarenko - 2014-09-19
    • QA: Igor Bondarenko
     
  • Igor Bondarenko

    Igor Bondarenko - 2014-09-19
    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.