#7804 Use OAuth token for github project validation

v1.2.0
closed
General
2015-08-20
2014-12-02
No

Use OAuth token for project validation or else github will return 403 (probably only if request limit is reached) and user will see "This project is unavailable for import" message

Discussion

  • Igor Bondarenko

    Igor Bondarenko - 2014-12-02

    Branch ib/7804

     
  • Dave Brondsema

    Dave Brondsema - 2014-12-02
    • status: review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2014-12-03
    • status: closed --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2014-12-03

    I already merged this to master, but have realized now that this means if a user goes to /p/import_project/github they will be immediately sent to a GitHub auth page (unless they have already approved github oauth). I think we should revert this change, since that is not a good UX.

    Perhaps we should consider having a server-side oauth token to use for these lookups where we don't want to force the user to authorize with github yet.

     
    • Igor Bondarenko

      Igor Bondarenko - 2014-12-04

      Actually, it's not related to this change. It was implemented this way in the first place (just rechecked with change reverted). Documentation also describes this behavior.

       
  • Dave Brondsema

    Dave Brondsema - 2014-12-04
    • status: in-progress --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2014-12-04

    Ok

     
  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.