Use OAuth token for project validation or else github will return 403 (probably only if request limit is reached) and user will see "This project is unavailable for import" message
I already merged this to master, but have realized now that this means if a user goes to /p/import_project/github they will be immediately sent to a GitHub auth page (unless they have already approved github oauth). I think we should revert this change, since that is not a good UX.
Perhaps we should consider having a server-side oauth token to use for these lookups where we don't want to force the user to authorize with github yet.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Actually, it's not related to this change. It was implemented this way in the first place (just rechecked with change reverted). Documentation also describes this behavior.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Branch
ib/7804I already merged this to master, but have realized now that this means if a user goes to /p/import_project/github they will be immediately sent to a GitHub auth page (unless they have already approved github oauth). I think we should revert this change, since that is not a good UX.
Perhaps we should consider having a server-side oauth token to use for these lookups where we don't want to force the user to authorize with github yet.
Actually, it's not related to this change. It was implemented this way in the first place (just rechecked with change reverted). Documentation also describes this behavior.
Ok