It might look the best but dynamic length coloring would have the advantage that it is obvious when a line ends which might be from a developers point of view more useful.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Good point, it might actually be helpful, even if its not a common approach. I think most I've seen color the whole line, or color the text (which would prevent the possibility of doing syntax highlighting with the text color). Maybe a few bigger examples would help us see how good it is or not.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
coloring of diff can be made dynamic based on length but I am not sure if this looks good.
Yeah that doesn't look very good to me either. I think coloring the whole row would be best.
It might look the best but dynamic length coloring would have the advantage that it is obvious when a line ends which might be from a developers point of view more useful.
Good point, it might actually be helpful, even if its not a common approach. I think most I've seen color the whole line, or color the text (which would prevent the possibility of doing syntax highlighting with the text color). Maybe a few bigger examples would help us see how good it is or not.
Done in https://forge-allura.apache.org/p/allura/git/merge-requests/197/