#7811 Coloring of long lines in diffs stops too early

v1.7.0
closed
None
General
2017-06-27
2015-01-05
Sworddragon
No

As the screenshot shows the coloring in a diff stops too early if a line is too long.

1 Attachments

Discussion

  • huzaifafaruqui

    huzaifafaruqui - 2017-03-05

    coloring of diff can be made dynamic based on length but I am not sure if this looks good.

     
    • Dave Brondsema

      Dave Brondsema - 2017-03-06

      Yeah that doesn't look very good to me either. I think coloring the whole row would be best.

       
      • Sworddragon

        Sworddragon - 2017-03-08

        It might look the best but dynamic length coloring would have the advantage that it is obvious when a line ends which might be from a developers point of view more useful.

         
        • Dave Brondsema

          Dave Brondsema - 2017-03-09

          Good point, it might actually be helpful, even if its not a common approach. I think most I've seen color the whole line, or color the text (which would prevent the possibility of doing syntax highlighting with the text color). Maybe a few bigger examples would help us see how good it is or not.

           
  • Dave Brondsema

    Dave Brondsema - 2017-04-25
    • status: open --> closed
    • assigned_to: huzaifafaruqui
    • Reviewer: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2017-06-27
    • Milestone: unreleased --> v1.7.0
     

Log in to post a comment.