#7813 Handle uppercase in email address all the time

v1.2.1
closed
Igor Bondarenko
sf-2 (994) 42cc (432)
General
Dave Brondsema
2015-08-20
2015-01-05
Dave Brondsema
No

In some places we canonicalize email addresses to their lowercase form, but not everywhere. This can lead to problematic inconsistencies. E.g. after entering an email address with some uppercase chars, and verifying it, the Account Prefs page says "Unknown addr obj EMAIL@ADDR.COM" and doesn't let you set it as default.

Related

Tickets: #7819

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-01-12
    • labels: --> sf-2, sf-current
     

  • Igor Bondarenko - 2015-01-13
    • labels: sf-2, sf-current --> sf-2, sf-current, 42cc
    • status: open --> in-progress
    • assigned_to: Igor Bondarenko
     

  • Igor Bondarenko - 2015-01-13
    • status: in-progress --> review
     

  • Igor Bondarenko - 2015-01-13

    Closed #711. {allura,forge-classic}:ib/7813

    I've added a couple of helper methods to EmailAddress and changed code to use them everywhere.

    Also changed _update_emails to save canonical name to user.email_addresses when adding new email. Seems like nothing else should be changed. Even if we have old emails stored on user record in not canonical form it won't affect user-by-email and similar lookups (since they all happen via EmailAddress and use new helpers), and for display purposes we don't really care if it's canonical or not.

     

  • Dave Brondsema

    Dave Brondsema - 2015-01-19
    • status: review --> closed
    • Reviewer: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2015-01-26
    • labels: sf-2, sf-current, 42cc --> sf-2, 42cc
     

  • Igor Bondarenko - 2015-02-18
    • Milestone: unreleased --> asf_release_1.2.1
     

Log in to post a comment.