#7857 Retry svnsync repo clone failures

v1.3.0
closed
sf-2 (994)
General
2015-08-20
2015-03-19
No

Repo clone tasks may fail due to 'svnsync' failing (remote server timeout or random error, etc). We should be smart about retrying those. Other failures that are a result of our code can happen too (failure to parse author, or timestamp properly) and it doesn't make sense to retry those.

I don't know about git/hg transfer errors. SVN seems to be the most common

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-03-20
    • labels: --> sf-current
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2015-03-23
    • labels: sf-current --> sf-current, sf-2
     
  • Dave Brondsema

    Dave Brondsema - 2015-03-23
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2015-03-23

    On branch db/7857

    To test, import an SVN repo and force an error (e.g. tweak command to use invalid arguments; or kill the svnsync command). Make sure that it logs appropriately and tries again. It should succeed if possible, or if it can't succeed then the failure email should still have the failure details.

     
  • Igor Bondarenko

    Igor Bondarenko - 2015-03-25
    • Reviewer: Igor Bondarenko
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-03-25
    • status: review --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-03-25

    I think we need to add description of new options (scm.import.retry_count & scm.import.retry_sleep_secs) to development.ini.

    Email to sfengineers@***.com contains failure details, but shows "None" instead of import source (I guess this is old bug, but can be fixed now). Admin email shows source just fine.

    sfengineers email:

    Forking/cloning repo t7857 in project test from None failed.
    

    admin email:

    Forking/cloning repo t7857 in project test from https://svn.code.sf.net/u/jetmind/test-svn failed. The SourceForge engineering team has been notified.
    

    Other than that all works fine for me.

     

    Last edit: Dave Brondsema 2015-04-24
  • Dave Brondsema

    Dave Brondsema - 2015-03-26
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2015-03-26

    Added to development.ini in db/7857

    Email contents come from an event handler hook, so fix for that is internal to SF in forge-classic:db/7857

     
  • Igor Bondarenko

    Igor Bondarenko - 2015-03-27
    • status: review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2015-04-06
    • labels: sf-current, sf-2 --> sf-2
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-06-18
    • Milestone: unreleased --> asf_release_1.3.0
     

Log in to post a comment.