#7862 Remove AMQP option for taskd

v1.3.1
closed
sf-1 (616)
General
2015-07-31
2015-03-26
No

The AMQP option for taskd theoretically allows for faster task processing, rather than just using the taskd polling of mongo. However the AMQP option is off by default, and I know at SourceForge we stopped using it a few years ago due to some issues with it. I don't think it's necessary, the mongo polling can be fast enough (especially if you have multiple taskd processes running).

There are also occasional problems with the name of allura/lib/async.py which houses the connection classes for it. There is a python package 'async' that the git and gitdb packages rely on (and thus we do, for ForgeGit). Due to some strange import mechanisms, I have occasionally seen 'import git' not work because when it imports 'async' it would get our allura/lib/async.py Of course this is not correct, and normally doesn't happen. But today I had that problem with running PyCharm tests on a mac. And I recall running into it in a different situation previously. It is hard to debug (particularly because one of the git libraries hides an ImportError and uses its own). It would be good to just completely avoid those potential problems.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-03-27
    • labels: --> sf-current, sf-1
    • status: in-progress --> review
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-03-30
    • Reviewer: Igor Bondarenko
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-03-30
    • status: review --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-03-30

    I see you have deleted references to allura/lib/async.py, but file still in the repo and it looks like nothing else depends on it. Should we delete it too?

    Other than that all looks fine, you can merge it after addressing the above.

     
  • Dave Brondsema

    Dave Brondsema - 2015-03-30
    • status: in-progress --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2015-03-30

    Lol, good catch. That was the whole point of this ticket :)

    Removed the async.py file and merged.

     
  • Dave Brondsema

    Dave Brondsema - 2015-04-06
    • labels: sf-current, sf-1 --> sf-1
     
  • Dave Brondsema

    Dave Brondsema - 2015-07-31
    • private: Yes --> No
     
  • Dave Brondsema

    Dave Brondsema - 2015-08-10
    • Milestone: unreleased --> v1.3.1
     

Log in to post a comment.