#7864 Error on google code import with paginated comments

v1.3.0
closed
General
2015-08-20
2015-03-30
No

Importing https://code.google.com/p/usbloader-gui/issues/detail?id=1769 fails with the following error.

I suspect it is due to the comment pagination which we probably don't handle at all.

Traceback (most recent call last):
  File "/var/local/allura/ForgeImporters/forgeimporters/base.py", line 131, in import_tool
    mount_point=mount_point, mount_label=mount_label, **kw)
  File "/var/local/allura/ForgeImporters/forgeimporters/google/tracker.py", line 123, in import_tool
    self.process_fields(ticket, issue)
  File "/var/local/allura/ForgeImporters/forgeimporters/google/tracker.py", line 164, in process_fields
    ticket.mod_date = dateutil.parser.parse(issue.get_issue_mod_date())
  File "/var/local/allura/ForgeImporters/forgeimporters/google/__init__.py", line 309, in get_issue_mod_date
    last_update = Comment(comments[-1], self.project_name)
  File "/var/local/allura/ForgeImporters/forgeimporters/google/__init__.py", line 391, in __init__
    tag.find('span', 'author').find(True, 'userlink'))
AttributeError: 'NoneType' object has no attribute 'find'

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-03-30
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2015-04-06
    • labels: import, google-code, sf-current --> import, google-code, sf-current, sf-2
     
  • Dave Brondsema

    Dave Brondsema - 2015-04-08
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2015-04-08

    Fix on db/7864

    Plus some other changes to make debugging a little bit better.

     
  • Igor Bondarenko

    Igor Bondarenko - 2015-04-09
    • Reviewer: Igor Bondarenko
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-04-09
    • status: review --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-04-09

    Looks good to me. All comments are imported. There are pyflake related test failures, though:

    ======================================================================
    ERROR: alluratest.test_syntax.test_pyflakes
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/var/local/env-allura/lib/python2.7/site-packages/nose-1.3.4-py2.7.egg/nose/case.py", line 197, in runTest
        self.test(*self.arg)
      File "/home/ibondarenko/ibondarenko-1274/forge/AlluraTest/alluratest/test_syntax.py", line 76, in test_pyflakes
        raise Exception('pyflakes failure, see stdout')
    Exception: pyflakes failure, see stdout
    -------------------- >> begin captured stdout << ---------------------
    ForgeBlog/forgeblog/main.py:118: redefinition of function 'external_feeds_list' from line 109
    
    Returned 0
    ForgeWiki/forgewiki/wiki_main.py:141: redefinition of function 'root_page_name' from line 132
    ForgeWiki/forgewiki/wiki_main.py:166: redefinition of function 'show_discussion' from line 162
    ForgeWiki/forgewiki/wiki_main.py:174: redefinition of function 'show_left_bar' from line 170
    ForgeWiki/forgewiki/wiki_main.py:182: redefinition of function 'show_right_bar' from line 178
    
     
    • Dave Brondsema

      Dave Brondsema - 2015-04-14

      Yes, make sure you get the newer version of pyflakes as specified in requirements.txt in this branch.

       
  • Dave Brondsema

    Dave Brondsema - 2015-04-14
    • status: in-progress --> review
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-04-15
    • status: review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2015-04-20
    • labels: import, google-code, sf-current, sf-2 --> import, google-code, sf-2
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-06-18
    • Milestone: unreleased --> asf_release_1.3.0
     

Log in to post a comment.