1. yes it should be the same. forgemail.url is used in outgoing emails. I think we could remove it and just use base_url but I didn't do that at this point.
4. the oauth.can_import_forum stuff is pretty old and doubtfully even used by anyone. So I don't want to document it more :)
6. Yes, intentionally. I grouped them with other related settings (outgoing mail, URLs, incoming mail) rather than by name since they seemed to fit better with other settings than with themselves
Inheritance is explained in the comments the top of the file.
Everything else addressed with a new commit on db/7870 branch and ready for review.
Last edit: Dave Brondsema 2015-04-20
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
{allura,forgehg}:db/7870
paster servework as expecteddevelopment.iniand make sure the comments and examples all make senseLooking really good overall! I have a few minor notes relating to the .ini file:
line 81forgemail.url <— what is this and is it normally the same as the base_url?line 114: typo inintegratinoline 126: what is a:login_fragment?lines 322/323could use an example use case.line 370: poll_interval = unit of time??lines: 57, 81, 390-394The forgemail settings are scattered.line 407: unit of time?line 410— example of a site-wide notification would be nice.line 426: A quick def of whatsoft-deletein context of alluraline 485: I’m getting a 404 for the python logging doc with that urlSome indication of how to use inheritance (like you did in the test.ini) to over-ride local settings would be handy. (this may be better in the docs)
A huge improvement overall!
1. yes it should be the same.
forgemail.urlis used in outgoing emails. I think we could remove it and just usebase_urlbut I didn't do that at this point.4. the
oauth.can_import_forumstuff is pretty old and doubtfully even used by anyone. So I don't want to document it more :)6. Yes, intentionally. I grouped them with other related settings (outgoing mail, URLs, incoming mail) rather than by name since they seemed to fit better with other settings than with themselves
Inheritance is explained in the comments the top of the file.
Everything else addressed with a new commit on
db/7870branch and ready for review.Last edit: Dave Brondsema 2015-04-20
Ok, looks great!