We should standardize on comment syntax, and add examples/comments for all config values that are possible.
Looking really good overall! I have a few minor notes relating to the .ini file:
lines: 57, 81, 390-394
Some indication of how to use inheritance (like you did in the test.ini) to over-ride local settings would be handy. (this may be better in the docs)
A huge improvement overall!
1. yes it should be the same. forgemail.url is used in outgoing emails. I think we could remove it and just use base_url but I didn't do that at this point.
4. the oauth.can_import_forum stuff is pretty old and doubtfully even used by anyone. So I don't want to document it more :)
6. Yes, intentionally. I grouped them with other related settings (outgoing mail, URLs, incoming mail) rather than by name since they seemed to fit better with other settings than with themselves
Inheritance is explained in the comments the top of the file.
Everything else addressed with a new commit on db/7870 branch and ready for review.
Ok, looks great!
Log in to post a comment.