Merge request viewing now (as of [#7836]) will fetch git info into existing git repositories. On deployments where the sysadmins don't want to do writes in existing git repos, we should use a tmp dir. The --shared
option for git clone
seems helpful to make it quick. Add an option, perhaps scm.merge_list.git.use_tmp_dir = true
, to do this.
Also log how long it took for each repo, since it is non-trivial code to run during a web request and may be too long for some repos. Logs will provide useful info.
Closed #783.
{allura,configtree}:ib/7882
Does https://forge-allura.apache.org/p/allura/pastebin/556dbf466d19cd2aa6c8f4d6 look like an ok cleanup to remove some duplication of
merge_base
andlog
? I am not sure about theself
vsc.app.repo
vs shared clone references though..Looks fine to me.
merge_request_commits
is called within downstream context asc.app.repo.merge_request.commits
, soself
should equalc.app.repo
there.Looks good. Added a cleanup commit and a logging commit.