#7882 Option to use a tmp dir for git ops on merge request view

v1.3.0
closed
sf-2 (994)
General
2015-08-20
2015-05-29
No

Merge request viewing now (as of [#7836]) will fetch git info into existing git repositories. On deployments where the sysadmins don't want to do writes in existing git repos, we should use a tmp dir. The --shared option for git clone seems helpful to make it quick. Add an option, perhaps scm.merge_list.git.use_tmp_dir = true, to do this.

Also log how long it took for each repo, since it is non-trivial code to run during a web request and may be too long for some repos. Logs will provide useful info.

Related

Tickets: #7836

Discussion

  • Igor Bondarenko

    Igor Bondarenko - 2015-06-01
    • status: open --> in-progress
    • assigned_to: Igor Bondarenko
     
  • Dave Brondsema

    Dave Brondsema - 2015-06-01
    • labels: sf-current --> sf-current, sf-2
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-06-02
    • status: in-progress --> review
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-06-02

    Closed #783. {allura,configtree}:ib/7882

     
  • Dave Brondsema

    Dave Brondsema - 2015-06-02

    Does https://forge-allura.apache.org/p/allura/pastebin/556dbf466d19cd2aa6c8f4d6 look like an ok cleanup to remove some duplication of merge_base and log? I am not sure about the self vs c.app.repo vs shared clone references though..

     
    • Igor Bondarenko

      Igor Bondarenko - 2015-06-02

      Looks fine to me. merge_request_commits is called within downstream context as c.app.repo.merge_request.commits, so self should equal c.app.repo there.

       
  • Dave Brondsema

    Dave Brondsema - 2015-06-02

    Looks good. Added a cleanup commit and a logging commit.

     
  • Dave Brondsema

    Dave Brondsema - 2015-06-02
    • status: review --> closed
    • Reviewer: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2015-06-15
    • labels: sf-current, sf-2 --> sf-2
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-06-18
    • Milestone: unreleased --> asf_release_1.3.0
     

Log in to post a comment.