#7913 Handle parsing of the output from git 2.4.0+

v1.3.2
closed
sf-2 (994)
SCM
2015-08-24
2015-07-07
No

Allura needs to handle parsing of the new git log output to ensure Allura will work with any git version.

Changes in the formatting are documented here.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-07-27
    • labels: --> sf-2, sf-current
     
  • Dave Brondsema

    Dave Brondsema - 2015-07-31
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2015-08-03
    $ GIT_PYTHON_GIT_EXECUTABLE=/home/dbrondsema/bin/git ./run_tests -p ForgeGit
    <DummyProcess(Thread-1, started daemon 140022074431808)> running nosetests  --cover-package=forgegit  {'cwd': 'ForgeGit'}
    ..............................................................................................................FF....................
    ======================================================================
    FAIL: test_log (forgegit.tests.model.test_repository.TestGitRepo)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/dbrondsema/dbrondsema-1019/forge/ForgeGit/forgegit/tests/model/test_repository.py", line 316, in test_log
        'rename_details': {}},
    AssertionError: Lists differ: [{'parents': ['df30427c488aeab... != [{'parents': ['df30427c488aeab...
    
    First differing element 0:
    {'parents': ['df30427c488aeab84b2352bdf88a3b19223f9d7a'], 'refs': ['HEAD -> master', 'foo'], 'committed': {'date': datetime.datetime(2010, 10, 7, 18, 44, 11), 'name': u'Rick Copeland', 'email': u'rcopeland@geek.net'}, 'message': u'Change README\n', 'rename_details': {}, 'id': '1e146e67985dcd71c74de79613719bef7bddca4a', 'authored': {'date': datetime.datetime(2010, 10, 7, 18, 44, 11), 'name': u'Rick Copeland', 'email': u'rcopeland@geek.net'}, 'size': None}
    {'parents': ['df30427c488aeab84b2352bdf88a3b19223f9d7a'], 'refs': ['HEAD', 'foo', 'master'], 'committed': {'date': datetime.datetime(2010, 10, 7, 18, 44, 11), 'email': u'rcopeland@geek.net', 'name': u'Rick Copeland'}, 'message': u'Change README\n', 'rename_details': {}, 'id': '1e146e67985dcd71c74de79613719bef7bddca4a', 'authored': {'date': datetime.datetime(2010, 10, 7, 18, 44, 11), 'email': u'rcopeland@geek.net', 'name': u'Rick Copeland'}, 'size': None}
    
    Diff is 2166 characters long. Set self.maxDiff to None to see it.
    -------------------- >> begin captured stdout << ---------------------
    Running setup_app() from allura.websetup
    
    --------------------- >> end captured stdout << ----------------------
    
    ======================================================================
    FAIL: test_log_file (forgegit.tests.model.test_repository.TestGitRepo)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/dbrondsema/dbrondsema-1019/forge/ForgeGit/forgegit/tests/model/test_repository.py", line 349, in test_log_file
        'rename_details': {}},
    AssertionError: Lists differ: [{'parents': ['df30427c488aeab... != [{'parents': ['df30427c488aeab...
    
    First differing element 0:
    {'parents': ['df30427c488aeab84b2352bdf88a3b19223f9d7a'], 'refs': ['HEAD -> master', 'foo'], 'committed': {'date': datetime.datetime(2010, 10, 7, 18, 44, 11), 'name': u'Rick Copeland', 'email': u'rcopeland@geek.net'}, 'message': u'Change README\n', 'rename_details': {}, 'id': '1e146e67985dcd71c74de79613719bef7bddca4a', 'authored': {'date': datetime.datetime(2010, 10, 7, 18, 44, 11), 'name': u'Rick Copeland', 'email': u'rcopeland@geek.net'}, 'size': 28}
    {'parents': ['df30427c488aeab84b2352bdf88a3b19223f9d7a'], 'refs': ['HEAD', 'foo', 'master'], 'committed': {'date': datetime.datetime(2010, 10, 7, 18, 44, 11), 'email': u'rcopeland@geek.net', 'name': u'Rick Copeland'}, 'message': u'Change README\n', 'rename_details': {}, 'id': '1e146e67985dcd71c74de79613719bef7bddca4a', 'authored': {'date': datetime.datetime(2010, 10, 7, 18, 44, 11), 'email': u'rcopeland@geek.net', 'name': u'Rick Copeland'}, 'size': 28}
    
    Diff is 1129 characters long. Set self.maxDiff to None to see it.
    -------------------- >> begin captured stdout << ---------------------
    Running setup_app() from allura.websetup
    
    --------------------- >> end captured stdout << ----------------------
    
    ----------------------------------------------------------------------
    Ran 132 tests in 593.344s
    
    FAILED (failures=2)
    finished nosetests  --cover-package=forgegit  {'cwd': 'ForgeGit'}
    
     
  • Dave Brondsema

    Dave Brondsema - 2015-08-13
    • summary: Handle parsing of the output from new git versions --> Handle parsing of the output from git 2.4.0+
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2015-08-13

    Fixed on branch db/7913

    See above for example of how to run with a different version of git.

     
  • Igor Bondarenko - 2015-08-14
    • Reviewer: Igor Bondarenko
     
  • Igor Bondarenko - 2015-08-14
    • status: review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2015-08-24
    • labels: sf-2, sf-current --> sf-2
     
  • Dave Brondsema

    Dave Brondsema - 2015-12-08
    • Milestone: unreleased --> v1.3.2
     

Log in to post a comment.