#7980 Fix pep8 and pyflakes violations

v1.3.2
closed
General
2015-10-06
2015-08-31
No

At this time, we have 502 pep8 violations (at line length 119) and 346 pyflakes violations. Would be good to clean those up some.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-09-21
    • labels: cleanup --> cleanup, sf-2, sf-current
     
  • Dave Brondsema

    Dave Brondsema - 2015-09-29
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2015-09-30
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2015-09-30

    db/7980

     
  • Igor Bondarenko

    Igor Bondarenko - 2015-10-01
    • status: review --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-10-01

    I'm getting an error trying to launch webapp

    $ paster serve /var/local/config/production.ini --reload
    Starting subprocess with file monitor
    Traceback (most recent call last):
      File "/var/local/env-allura/bin/paster", line 9, in <module>
        load_entry_point('PasteScript==1.7.4.2', 'console_scripts', 'paster')()
      File "/var/local/env-allura/lib/python2.7/site-packages/PasteScript-1.7.4.2-py2.7.egg/paste/script/command.py", line 104, in run
        invoke(command, command_name, options, args[1:])
      File "/var/local/env-allura/lib/python2.7/site-packages/PasteScript-1.7.4.2-py2.7.egg/paste/script/command.py", line 143, in invoke
        exit_code = runner.run(args)
      File "/var/local/env-allura/lib/python2.7/site-packages/PasteScript-1.7.4.2-py2.7.egg/paste/script/command.py", line 238, in run
        result = self.command()
      File "/var/local/env-allura/lib/python2.7/site-packages/PasteScript-1.7.4.2-py2.7.egg/paste/script/serve.py", line 284, in command
        relative_to=base, global_conf=vars)
      File "/var/local/env-allura/lib/python2.7/site-packages/PasteScript-1.7.4.2-py2.7.egg/paste/script/serve.py", line 321, in loadapp
        **kw)
      File "/var/local/env-allura/lib/python2.7/site-packages/PasteDeploy-1.5.0-py2.7.egg/paste/deploy/loadwsgi.py", line 247, in loadapp
        return loadobj(APP, uri, name=name, **kw)
      File "/var/local/env-allura/lib/python2.7/site-packages/PasteDeploy-1.5.0-py2.7.egg/paste/deploy/loadwsgi.py", line 272, in loadobj
        return context.create()
      File "/var/local/env-allura/lib/python2.7/site-packages/PasteDeploy-1.5.0-py2.7.egg/paste/deploy/loadwsgi.py", line 710, in create
        return self.object_type.invoke(self)
      File "/var/local/env-allura/lib/python2.7/site-packages/PasteDeploy-1.5.0-py2.7.egg/paste/deploy/loadwsgi.py", line 146, in invoke
        return fix_call(context.object, context.global_conf, **context.local_conf)
      File "/var/local/env-allura/lib/python2.7/site-packages/PasteDeploy-1.5.0-py2.7.egg/paste/deploy/util.py", line 56, in fix_call
        val = callable(*args, **kw)
      File "/home/ibondarenko/ibondarenko-1154/forge/Allura/allura/config/middleware.py", line 62, in make_app
        return _make_core_app(root, global_conf, full_stack, **app_conf)
      File "/home/ibondarenko/ibondarenko-1154/forge/Allura/allura/config/middleware.py", line 137, in _make_core_app
        app = AlluraTimerMiddleware(app, app_conf)
      File "/var/local/env-allura/lib/python2.7/site-packages/TimerMiddleware-0.4.4-py2.7.egg/timermiddleware/__init__.py", line 179, in __init__
        t.decorate(self)
      File "/var/local/env-allura/lib/python2.7/site-packages/TimerMiddleware-0.4.4-py2.7.egg/timermiddleware/__init__.py", line 96, in decorate
        TimingDecorator(getattr(self.target_class, name),
    AttributeError: 'module' object has no attribute 'unified_diff'
    

    The only change related to "unified_diff" I see is in the Allura/allura/model/repository.py

    -from difflib import SequenceMatcher, unified_diff
    +from difflib import SequenceMatcher
    
     
  • Dave Brondsema

    Dave Brondsema - 2015-10-01
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2015-10-01

    Pushed a fix for that.

     
  • Dave Brondsema

    Dave Brondsema - 2015-10-05
    • labels: cleanup, sf-2, sf-current --> cleanup, sf-2
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-10-06
    • status: review --> closed
    • Reviewer: Igor Bondarenko
     
  • Dave Brondsema

    Dave Brondsema - 2015-12-08
    • Milestone: unreleased --> v1.3.2
     

Log in to post a comment.