#7998 Adding attachment to wiki loses your text changes

v1.4.0
closed
General
2016-01-11
2015-10-05
No

When editing a wiki page and adding or removing an attachment, any changes you may have made to the wiki text get lost.

I'd suggest we make the add & delete attachments into ajax calls. (Another option would be submit the wiki text form too and controller would handle both types of changes at once). Ajax would be a nice direction towards someday allowing drag/drop of images into a markdown editor and auto-attach and insert [[img src=...]] for you.

Discussion

  • Igor Bondarenko

    Igor Bondarenko - 2015-12-09
    • labels: ux --> ux, 42cc
    • status: open --> in-progress
    • assigned_to: Igor Bondarenko
     
  • Dave Brondsema

    Dave Brondsema - 2015-12-14
    • labels: ux, 42cc --> ux, 42cc, sf-current, sf-2
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-12-23

    Closed #878.

    ib/7998

     
  • Igor Bondarenko

    Igor Bondarenko - 2015-12-23
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2016-01-04
    • status: review --> in-progress
    • Reviewer: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2016-01-04

    This is great. Some thoughts to polish it up even more:

    • In def attach, not doing the redirect when AJAX is good. Can you do that when deleting an attachment too?
    • Using onsubmit attributes in HTML isn't the best way to set up JS event handlers. Could you change it to jquery's .on('submit')? That will also mean you don't need to pass onsubmit strings through the templates. Just have an appropriate selector to find the form for the .on call.
     
  • Igor Bondarenko

    Igor Bondarenko - 2016-01-08
    • status: in-progress --> review
     
  • Igor Bondarenko

    Igor Bondarenko - 2016-01-08

    Closed #883. ib/7998a

     
  • Dave Brondsema

    Dave Brondsema - 2016-01-08
    • status: review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2016-01-11
    • labels: ux, 42cc, sf-current, sf-2 --> ux, 42cc, sf-2
     
  • Dave Brondsema

    Dave Brondsema - 2016-04-11
    • Milestone: unreleased --> v1.4.0
     

Log in to post a comment.