#8007 Broken icon images when running under gunicorn

v1.3.2
closed
Dave Brondsema
sf-1 (616)
General
Igor Bondarenko
2015-11-02
2015-10-20
Dave Brondsema
No

paster and mod_wsgi are forgiving with URLs like /p/test//icon but gunicorn doesn't help fix that double slash.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-10-20
    • status: in-progress --> review
     

  • Dave Brondsema

    Dave Brondsema - 2015-10-20

    db/8007

     

  • Igor Bondarenko - 2015-10-21
    • Reviewer: Igor Bondarenko
     

  • Igor Bondarenko - 2015-10-21

    Looks good. Merged

    I have removed slash from the forum icon path also:

    ForgeDiscussion/forgediscussion/templates/discussionforums/admin_forums.html
43:                <img src="{{forum.url()}}/icon" alt="Forum icon"/>

    I can't check how it works due to [#8008], but Forum.url adds / to the end of the url it returns (see ForgeDiscussion/forgediscussion/model/forum.py:103), so I'm pretty sure the change is right.

     

    Related

    Tickets: #8008

  • Igor Bondarenko - 2015-10-21
    • status: review --> closed
     

  • Dave Brondsema

    Dave Brondsema - 2015-11-02
    • labels: sf-1, sf-current --> sf-1
     

  • Dave Brondsema

    Dave Brondsema - 2015-12-08
    • Milestone: unreleased --> v1.3.2
     

Log in to post a comment.