#8010 Markdown editor does not load when url hash contains slashes

v1.4.0
closed
General
2016-01-11
2015-10-23
No

Compare https://forge-allura.apache.org/p/allura/tickets/7924/#d1d2/ed24/f3ed and https://forge-allura.apache.org/p/allura/tickets/7924/#d1d2 for example

In the first case markdown editor does not load and console has the following errors:

Uncaught Error: Syntax error, unrecognized expression: #d1d2\/ed24/f3ed.title-pane
(index):6200 Uncaught TypeError: $(...).tagsInput is not a function
(index):6334 Uncaught TypeError: Cannot read property 'CodeMirror' of undefined

in the second case editor is loading just fine

Chrome Version 46.0.2490.71 (64-bit), Ubuntu

Discussion

  • Igor Bondarenko

    Igor Bondarenko - 2015-12-09
    • labels: --> 42cc
    • status: open --> in-progress
    • assigned_to: Igor Bondarenko
     
  • Dave Brondsema

    Dave Brondsema - 2015-12-14
    • labels: 42cc --> 42cc, sf-2, sf-current
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-12-21
    • status: in-progress --> review
     
  • Igor Bondarenko

    Igor Bondarenko - 2015-12-21

    Closed #876. ib/8010

     
  • Dave Brondsema

    Dave Brondsema - 2016-01-04
    • status: review --> in-progress
    • Reviewer: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2016-01-04

    Do you know if this code is still relevant? I was looking for where title-pane came from and found Allura/allura/templates/widgets/thread_header.html but as best I can tell that isn't used anywhere. I only see ForgeDiscussion/forgediscussion/templates/discussion_widgets/thread_header.html being used.

    If it really is dead code, I think it'd be better to do some cleanup rather than changing it.

     
    • Igor Bondarenko

      Igor Bondarenko - 2016-01-05

      Seems like that's really the case, thanks. Will remove corresponsing js.

       
  • Igor Bondarenko

    Igor Bondarenko - 2016-01-06
    • status: in-progress --> review
     
  • Igor Bondarenko

    Igor Bondarenko - 2016-01-06

    Closed #885. Updated ib/8010

     
  • Dave Brondsema

    Dave Brondsema - 2016-01-06
    • status: review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2016-01-11
    • labels: 42cc, sf-2, sf-current --> 42cc, sf-2
     
  • Dave Brondsema

    Dave Brondsema - 2016-04-11
    • Milestone: unreleased --> v1.4.0
     

Log in to post a comment.