The moderation page should have a field to filter by a username - then it will be easier to get a list of all the posts by a user in that forum, and select-all to mark as spam.
Also, when in the regular view of a post and you click "Spam" and the message goes away, we should show a little message box in its place that explains what just happened, and a link to go over to the moderation view and see all posts by the user (so project admins know that is possible and have an easy way to get there). An undo link there would be very nice too.
Closed #874, #875
ib/8020a
I have removed the 'flags' input on the moderation page as well as dead code related to it. Can you check it over on
db/8020
?This looks good and the only issue I found is that the undo doesn't properly update the number of posts in the thread. This number can be seen in the forums list of threads. In
def moderate
the undo action just sets the status, but the other actions call methods which do several things including updateself.thread.num_replies
or callupdate_stats
."flags" changes look good to me. Will fix posts count
Closed #886.
ib/8020b
Why is the -1 removed? Was it kind of like a bug before maybe, and the
flush()
calls change the behavior or something?I got the wrong counts doing this:
Also, the tests that had
num_replies
values changed is a little concerning. Unless the tests themselves were wrong before, those numbers shouldn't have to change.Hm... I saw the exact behavior you described before -1 was removed, that is the reason it was removed. I re-checked just now and this scenario works ok for me (3 initial posts -" spam" changes to 2 - "undo" changes back to 3). Could you re-check? Maybe make sure docker containers are restarted and running updated code? Thanks
Works for me now, after ensuring everything was updated.