Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, ccruz, deshani, and 11 others

#8027 Fix licensing of several files

Milestone: v1.3.2

Status: closed

Owner: Dave Brondsema

Labels: licensing (6) sf-2 (994)

Component: General

Reviewer: Heith Seewald

Updated: 2015-11-30

Created: 2015-11-23

Creator: Dave Brondsema

Private: No

Allura/allura/public/nf/js/pb.transformie.min.js
- MIT license
Allura/allura/lib/widgets/resources/css/jquery.tagsinput.css
- corresponding JS is MIT
Allura/allura/lib/widgets/resources/css/colorPicker.css
- corresponding JS is MIT
Allura/allura/lib/widgets/resources/css/jqfontselector.css
- corresponding JS is MIT
Allura/allura/public/nf/css/forge/hilite.css
- from commit 86903da02f87a2aba44c33ab5a12bbe19f638c7f
- similar looking stuff here, not sure of actual source:
  - https://github.com/modocache/modocachejp/blob/master/modocachejp/static/less/codehilite.less
  - https://gist.github.com/theodox/4fefeb539f1d8ec341b0
several Makefile, make.bat for sphinx
- BSD

Discussion

Dave Brondsema - 2015-11-23

status: open --> in-progress

assigned_to: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-11-23

status: in-progress --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-11-23

db/8027

Double check the license is correct for the changed files, and that they match between LICENSE files and inline header. (rat-excludes.txt doesn't list all the changed files, since the "rat" tool correctly identifies some of them).

Run "rat" (see scripts/src-license-check/README.txt) and make sure there are no unapproved files.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-11-23

labels: licensing --> licensing, sf-current, sf-2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2015-11-25

Reviewer: Heith Seewald
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2015-11-25

Nice job finding these issues, Dave!

I'm trying to follow your steps for QA -- but I appear to have a RAT problem...

sb 1024 cd scripts/src-license-check && ant

So I tried running rat manually (from the 'src-license-check' directory):

java -jar /opt/ant/lib/apache-rat-0.11.jar -d ../ -E ../../rat-excludes.txt

This actually gave me some output -- so that gave me the impression that things are just taking too long (like you suggested). However, even if I filter out all the node libs, it still runs for 30+ minutes without any output. This is the same result I got on my local machine.

Any ideas?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Igor Bondarenko - 2015-11-25
  
  I had the same slowness problem with rat once. Fixed it by making a fresh clone of the repo and running check on that. I think git index and all the temporary files from working repo make it slow.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Heith Seewald - 2015-11-25
    
    Thanks, Igor -- I'll give that a shot.
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-11-30

labels: licensing, sf-current, sf-2 --> licensing, sf-2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2015-11-30

status: review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2015-11-30

Looks great :)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-12-08

Milestone: unreleased --> v1.3.2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.