#8027 Fix licensing of several files

v1.3.2
closed
General
Heith Seewald
2015-11-30
2015-11-23
No

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-11-23
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2015-11-23
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2015-11-23

    db/8027

    Double check the license is correct for the changed files, and that they match between LICENSE files and inline header. (rat-excludes.txt doesn't list all the changed files, since the "rat" tool correctly identifies some of them).

    Run "rat" (see scripts/src-license-check/README.txt) and make sure there are no unapproved files.

     
  • Dave Brondsema

    Dave Brondsema - 2015-11-23
    • labels: licensing --> licensing, sf-current, sf-2
     
  • Heith Seewald

    Heith Seewald - 2015-11-25
    • Reviewer: Heith Seewald
     
  • Heith Seewald

    Heith Seewald - 2015-11-25

    Nice job finding these issues, Dave!

    I'm trying to follow your steps for QA -- but I appear to have a RAT problem...

    sb 1024
    cd scripts/src-license-check && ant
    

    So I tried running rat manually (from the 'src-license-check' directory):

    java -jar /opt/ant/lib/apache-rat-0.11.jar -d ../ -E ../../rat-excludes.txt
    

    This actually gave me some output -- so that gave me the impression that things are just taking too long (like you suggested). However, even if I filter out all the node libs, it still runs for 30+ minutes without any output. This is the same result I got on my local machine.

    Any ideas?

     
    • Igor Bondarenko

      Igor Bondarenko - 2015-11-25

      I had the same slowness problem with rat once. Fixed it by making a fresh clone of the repo and running check on that. I think git index and all the temporary files from working repo make it slow.

       
      • Heith Seewald

        Heith Seewald - 2015-11-25

        Thanks, Igor -- I'll give that a shot.

         
  • Dave Brondsema

    Dave Brondsema - 2015-11-30
    • labels: licensing, sf-current, sf-2 --> licensing, sf-2
     
  • Heith Seewald

    Heith Seewald - 2015-11-30
    • status: review --> closed
     
  • Heith Seewald

    Heith Seewald - 2015-11-30

    Looks great :)

     
  • Dave Brondsema

    Dave Brondsema - 2015-12-08
    • Milestone: unreleased --> v1.3.2
     

Log in to post a comment.