Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, deshani, dill0wn, and 10 others

#8046 Don't duplicate titles on neighborhood pages

Milestone: v1.4.0

Status: closed

Owner: Heith Seewald

Labels: ux (103) neighborhood (8) sf-current (14) sf-4 (350)

Component: General

Reviewer: Dave Brondsema

Updated: 2016-02-05

Created: 2016-01-15

Creator: Dave Brondsema

Private: No

When on neighborhood level pages like a wiki, the project and neighborhood name are both displayed but they are the same and it looks weird, especially if they run into each other. We should omit one on pages of that type.

Discussion

Heith Seewald - 2016-01-20

I created several neighborhood level pages and projects, but was unable to recreate this.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-20

It is visible on the default "adobe" neighborhood tools, e.g. the wiki: /adobe/wiki/Home/ However it shows on 2 separate lines, so there is a theme difference going on. I also note that if you don't have an icon set for the neighborhood, it doesn't show the icon+name on the right hand side at all.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-01-20

status: open --> in-progress

assigned_to: Heith Seewald
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-01-20

Ah yes, I see it now. Thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-01-20

So the "View More Projects" link is supposed to be under the icon and the nbhd name is supposed to be to the left or something?

I attached a couple of pictures showing how it is now and how I think it was supposed to look. We can still make it look like this -- or we could just lose the title all together for the nbhd icon.

templates/jinja_master/theme_macros.html:136

/* We can just lose this line */ <h1><a href="{{project.neighborhood.url()}}">{{project.neighborhood.name}}</a></h1>

(trans.png is a bad name -- it's just a picture showing what changed)

Last edit: Heith Seewald 2016-01-20

new.png

old.png

trans.png
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Dave Brondsema - 2016-01-20
  
  Yea that's how I think it should look. (Its similar to how the SF theme does it).
  
  I think having the neighborhood title is good (not just the icon) when you're on one of the projects within the neighborhood. Although long neighborhood titles could run in to long project names sometimes.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-01-23

status: in-progress --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-01-23

Review at: hs/8046

I also ended up removing the url validation that prevented using relative urls in the project_list_url.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-25

labels: ux, neighborhood --> ux, neighborhood, sf-current, sf-4
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-25

status: review --> in-progress

Reviewer: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-25

project_header_right has a div mismatch in it

I think its better to have the Neighborhood icon & title on the left, since it's the main header for the page.

If you go to ProjectHomeApp and enable it (set a positive max_instances) then you can install the specialized "Home" tool which lives at the neighborhood url /adobe/ for example, directly. It has a different layout. The left-side header there looks good and can be a model for the other pages within the neighborhood level.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-01-25

status: in-progress --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-01-25

I made the changes and force pushed to: hs/8046.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-26

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-26

Looking nice and easy :) Just a few little things:

project_header_right has a div mismatch in it, still from an earlier commit

.neighborhood_icon_left looks like unnecessary rules, since there's no HTML using it

text-align: end may not be supported in all browsers. right would be better.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-01-27

status: review --> in-progress
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-01-27

Made those changes and force pushed to hs/8046.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-01-27

status: in-progress --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-02-05

status: review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-04-11

Milestone: unreleased --> v1.4.0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.