When on neighborhood level pages like a wiki, the project and neighborhood name are both displayed but they are the same and it looks weird, especially if they run into each other. We should omit one on pages of that type.
I created several neighborhood level pages and projects, but was unable to recreate this.
It is visible on the default "adobe" neighborhood tools, e.g. the wiki: /adobe/wiki/Home/ However it shows on 2 separate lines, so there is a theme difference going on. I also note that if you don't have an icon set for the neighborhood, it doesn't show the icon+name on the right hand side at all.
Ah yes, I see it now. Thanks.
So the "View More Projects" link is supposed to be under the icon and the nbhd name is supposed to be to the left or something?
I attached a couple of pictures showing how it is now and how I think it was supposed to look. We can still make it look like this -- or we could just lose the title all together for the nbhd icon.
/* We can just lose this line */
(trans.png is a bad name -- it's just a picture showing what changed)
Yea that's how I think it should look. (Its similar to how the SF theme does it).
I think having the neighborhood title is good (not just the icon) when you're on one of the projects within the neighborhood. Although long neighborhood titles could run in to long project names sometimes.
Review at: hs/8046
I also ended up removing the url validation that prevented using relative urls in the project_list_url.
I made the changes and force pushed to: hs/8046.
Looking nice and easy :) Just a few little things:
Made those changes and force pushed to hs/8046.
Log in to post a comment.