#8060 Commit overview and diff changes are a bit messed up

v1.14.0
closed
nobody
None
General
nobody
2022-09-23
2016-02-25
Sworddragon
No

For example in this commit ( https://sourceforge.net/p/tvoip/code/ci/e5b776d7226deb0db4db85e666eaf1d0eb63259f/ ) on the file /src/index.css the diff shows that the line " position: absolute;" has been removed and immediately it shows that the line " position: absolute;" has been added.

Also the overview shows changes on directories just because files in it have changed. But the changed file implies this already so this redundant information could be removed for a better overview.

At last I'm seeing for example in this commit ( https://sourceforge.net/p/tvoip/code/ci/24a8c42d51511a9f209f505b5f80721815235596/ ) that the file src/lib/string_to_json.js has been copied to src/lib/throw_exception.js. I wonder where the information has been gained from that exactly this file has been copied as technically src/lib/throw_exception.js is just a newly added file. In reality I have indeed copied and modified a random file but at other commits where I have done the same the overview shows correctly that they are newly added files.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2016-02-29

    We have [#7949] for the 2nd issue mentioned. Not sure offhand why the diff output and rename detection is working exacly that way. For the most part I believe we just show the output of git commands themselves.

     

    Related

    Tickets: #7949

  • Dave Brondsema

    Dave Brondsema - 2022-07-26

    I think the original report was an issue when files don't have \n at the end of the last line. I've fixed that on branch db/8060

    To test this, make a local git repo and commit files to it. Have the last line with or without a trailing newline to see what the diff looks like. echo -n 'aabc' > foo.txt or >> foo.txt is way to append to a file without a newline. nano and vim make it pretty hard to save files without a trailing newline actually.

     
  • Kenton Taylor - 2022-07-27
    • status: open --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2022-09-23
    • Milestone: unreleased --> v1.14.0
     

Log in to post a comment.