#8164 Merge requests should notify the submitter of changes HAS MIGRATION SCRIPT

v1.8.0
closed
General
nobody
2018-02-05
2017-09-19
No

The person that submits a merge request should get subscribed to it. Would be nice to have a subscribe icon button also, so that other people can subscribe (like tickets etc work). We'll have to adjust the message text a bit, the word "you" here is directed at project admins only:

has requested that you merge changes

Related

Tickets: #8123

Discussion

  • Dave Brondsema

    Dave Brondsema - 2017-09-26
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2017-09-26
    • summary: Merge requests should notify the submitter of changes --> Merge requests should notify the submitter of changes HAS MIGRATION SCRIPT
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2017-09-26

    db/8164

    QA, to reproduce:

    • be on master, log in as a user that is not admin of a project (e.g. "root"), fork a repo, and submit a merge request. (The repo needs to be non-empty, merge request can actually be no changes though)
    • as project admin, change and/or comment on the merge request
    • watch email logs, e.g. docker-compose logs -f outmail and see notifications. See that the TO: line goes to the project admin only

    Now:

    • switch to this branch
      • docker-compose restart taskd to get some of the changes in effect
    • create new merge request, comment/change as proj admin
    • confirm merge request emails are sent to submitter now
    • and icon to subscribe/unsubscribe to merge requests
    • activity stream entries for all merge request changes, shows up for the user & project
    • run docker-compose run taskd paster script docker-dev.ini ../scripts/migrations/032-subscribe-merge-request-submitters.py to resubscribe prior merge requests. Can confirm on /auth/subscriptions/ page.
     
  • Kenton Taylor

    Kenton Taylor - 2017-09-28
    • status: review --> closed
     
  • Kenton Taylor

    Kenton Taylor - 2017-09-28

    Merged.

     
  • Dave Brondsema

    Dave Brondsema - 2018-02-05
    • Milestone: unreleased --> v1.8.0
     

Log in to post a comment.