#8256 Drag-to-reorder on touch screens

unreleased
closed
None
General
2018-10-31
2018-10-29
No

The current mechanism backing drag-to-reorder (jQ UI) on project screenshots doesn't fully work on touch screens. Evaluate a replacement and implement.

Discussion

  • Kenton Taylor

    Kenton Taylor - 2018-10-29
    • status: in-progress --> review
     
  • Kenton Taylor

    Kenton Taylor - 2018-10-29

    kt/8256

     
  • Dave Brondsema

    Dave Brondsema - 2018-10-30

    One thing we'll need to do when adding a 3rd-party file is track the licensing for it. So what you'll need to do is update our LICENSE and Allura/LICENSE files and add a little section to mention that filename and the MIT license like the other sections in that file. And then add it into our rat-excludes.txt file which is for the "release audit tool" which checks licenses of all our files.

     
    • Kenton Taylor

      Kenton Taylor - 2018-10-30

      License files updated on new rev.

       
  • Dave Brondsema

    Dave Brondsema - 2018-10-30
    • status: review --> open
    • Reviewer: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2018-10-30

    And what about other places that use old .sortable(? Looks like they are:

    • SortableRepeatedMixin / sortable_repeated_field.js:
      • features list
      • tracker field management custom fields
      • tracker milestone table
    • ticket-list.js which is used on ticket search results gear icon, you can reorder the columns (I didn't even know that was possible!)

    The SortableRepeated stuff seems messy to me, at least the tracker field management is a very messy page. May do a proof of concept moving the features list to use the new sortable, and we can move towards dropping SortableRepeated widgets?

     
    • Kenton Taylor

      Kenton Taylor - 2018-10-30

      SortableRepeatedMixin work ticketed separately at [#8258]

       

      Related

      Tickets: #8258

  • Dave Brondsema

    Dave Brondsema - 2018-10-31
    • status: open --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2018-10-31

    I tweaked the code a little bit to check if responsive template overriders were enabled as the indicator, rather than the current theme. This is so that other existing themes aren't impacted e.g. forge-allura here runs theme with just a few changes to the header & footer.

    Merged.

     

Log in to post a comment.