If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
There's also weird regex matching behavior when typing in the editor. @foo. will trigger the autocomplete again when you type the . It also happens with other punctuation like @foo=. And can happen at the beginning like @//.?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
In the test, since @nouser1 isn't a user the new assertion isn't a very strong one. Better to test with test@admin1.com I think. Besides that I think this will be good to merge to handle the server-side parsing.
Note my comment above about the behavior when typing in the editor too. That is really a separate issue but similar. Not too critical, so can be dealt with later if you wish.
👍
1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi.. acutually I missed to replace nouser with correct one. Now I updated the branch. Yeah we can keep this ticket open until I fix the editor typing improvement.
Thanks
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
There's also weird regex matching behavior when typing in the editor.
@foo.will trigger the autocomplete again when you type the.It also happens with other punctuation like@foo=. And can happen at the beginning like@//.?Hi.. @brondsem
I made branch
ss/8299and improved regex by adding\B. So it will not catch things likejohndoe@foo.comandjohndoe@foo.In the test, since
@nouser1isn't a user the new assertion isn't a very strong one. Better to test withtest@admin1.comI think. Besides that I think this will be good to merge to handle the server-side parsing.Note my comment above about the behavior when typing in the editor too. That is really a separate issue but similar. Not too critical, so can be dealt with later if you wish.
Hi.. acutually I missed to replace
nouserwith correct one. Now I updated the branch. Yeah we can keep this ticket open until I fix the editor typing improvement.Thanks
Merged ss/8299
Hi..
I have updated autocomplete regex in ss/8299
Thanks
Nice, works better now :)