Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, ccruz, deshani, and 11 others

#8334 Python-ombed has no timeout by default

Milestone: v1.12.0

Status: closed

Owner: Dave Brondsema

Labels: None

Component: General

Reviewer: nobody

Updated: 2019-10-04

Created: 2019-09-30

Creator: Dave Brondsema

Private: No

Library https://github.com/abarmat/python-oembed/ has a pull request https://github.com/abarmat/python-oembed/pull/9/files to support it, but its not merged.

Discussion

Dave Brondsema - 2019-09-30

status: in-progress --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2019-09-30

Fixed on db/8334

Tests don't cover this that I can tell, they mock out oembed actual requests. Test manually with [[embed url=...] in any markdown area. I also tested with a value of 0.0001 to confirm that a timeout will be raised.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kenton Taylor - 2019-10-01

status: review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2019-10-04

Milestone: unreleased --> v1.12.0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.