#8334 Python-ombed has no timeout by default

v1.12.0
closed
None
General
nobody
2019-10-04
2019-09-30
No

Library https://github.com/abarmat/python-oembed/ has a pull request https://github.com/abarmat/python-oembed/pull/9/files to support it, but its not merged.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2019-09-30
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2019-09-30

    Fixed on db/8334

    Tests don't cover this that I can tell, they mock out oembed actual requests. Test manually with [[embed url=...] in any markdown area. I also tested with a value of 0.0001 to confirm that a timeout will be raised.

     
  • Kenton Taylor

    Kenton Taylor - 2019-10-01
    • status: review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2019-10-04
    • Milestone: unreleased --> v1.12.0
     

Log in to post a comment.