#8404 SMTP maximum allowed line length (part 2)

v1.14.0
closed
Dillon Walls
None
General
Dave Brondsema
2022-09-23
2021-12-16
Dillon Walls
No

There is a previous ticket which addressed this, but apparently the problem lingers...

A sourceforge user noticed the problem. I dug into it, and the problem lies with the email headers, not the body. Due to our reply-thread emails, the References email header can be quite long. This was tripping SMTP's line length limit.

I have pushed some fixes to dw/smtp_line_length

Discussion

  • Dave Brondsema

    Dave Brondsema - 2021-12-17
    • allura still supports python 3.6 so from __future__ import annotations won't work (added in 3.7). I believe the Apache jenkins build uses 3.6 and will error on that.
      • that said, email.message is available in 3.6 so can be imported & used without any __future__ stuff
    • can we keep MAX_MAIL_LINE_OCTETS at 990. that seems more conservative and safe since http://www.jebriggs.com/blog/2010/07/smtp-maximum-line-lengths/ indicates some email servers have a limit of 990
    • would be nice to have the commit message start with this ticket number: [#8404] ...
     

  • Dillon Walls - 2021-12-17

    good feedback. I updated and pushed to dw/8404

     

  • Dave Brondsema

    Dave Brondsema - 2021-12-20
    • status: open --> closed
    • assigned_to: Dillon Walls
    • Reviewer: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2022-09-23
    • Milestone: unreleased --> v1.14.0
     

Log in to post a comment.