#8447 restrict thread pre-caching to not be so greedy

v1.14.0
closed
None
General
nobody
2022-09-23
2022-07-13
No

We recently added up-front db caching on thread pages so that we can grab all of the attachments, artifactreferences, etc. up front instead of having 25 separate db lookups. The problem is we're grabbing ALL of them. So on a very long thread with 500 replies, we're caching 500 values rather than only those that we care about on this page.

Discussion

  • Dillon Walls - 2022-07-13
    • status: open --> in-progress
    • assigned_to: Dillon Walls
     
  • Dillon Walls - 2022-07-14
    • status: in-progress --> review
     
  • Dillon Walls - 2022-07-14

    my changes are on dw/8447
    - only pre-fetches and caches attributes for the current window of posts (i.e. respecting ?page=3&limit=50)

     
  • Guillermo Cruz - 2022-07-25
    • status: review --> closed
     
  • Guillermo Cruz - 2022-07-25

    merged

     
  • Dave Brondsema

    Dave Brondsema - 2022-09-23
    • Milestone: unreleased --> v1.14.0
     

Log in to post a comment.