looks like you forgot to add jquery-migrate-3.4.0.js?
jquery-base.js can be deleted
there are 2 LICENSE file that mention jquery-base.js, we need to update those with the 3 new jquery related files
also update rat-excludes.txt for the new files. That is used by https://creadur.apache.org/rat/ to make sure we have acceptable licenses for all our files
Note that this does not have any impact at all on the ajax callbacks of the same name passed through the options object, which continue to exist and are not deprecated. This only affects the jqXHR methods.
so I think we don't need to change (and maybe must not change?) code like this. Maybe Allura doesn't need any ajax changes?
Yes, I did missed that notice about the ajax methods, thanks!. I reverted the commit with the ajax changes, tested and we really don't need them as you pointed out.
I also added the missing jquery-migrate file and updated license files with new file paths.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
jquery-migrate-3.4.0.js?jquery-base.jscan be deletedLICENSEfile that mention jquery-base.js, we need to update those with the 3 new jquery related filesrat-excludes.txtfor the new files. That is used by https://creadur.apache.org/rat/ to make sure we have acceptable licenses for all our filesso I think we don't need to change (and maybe must not change?) code like this. Maybe Allura doesn't need any ajax changes?
$.ajax({ url: "%suser_search", dataType: "json", data: { term: request.term }, - success: function (data) { + done: function (data) { response(data.users); } });Yes, I did missed that notice about the
ajaxmethods, thanks!. I reverted the commit with the ajax changes, tested and we really don't need them as you pointed out.I also added the missing
jquery-migratefile and updated license files with new file paths.