#5120 Increase visibility of "HEAD" URLs (and git/hg equivalent) [ss1006]

v1.0.0
closed
SCM
2015-08-20
2012-10-15
Chris Tsai
No

[forge:site-support:#1006]

Before the project "upgrades", it was possible to link via URL to the HEAD version of a file in svn. It seems like this is no longer possible, and one can only link to a particular version of a file.

Please can you re-enable this important missing functionality.

As per [#4130], URLs like what he wants (eg. https://sourceforge.net/p/lives/code/HEAD/tree/) already work, but it's really quite hidden and I don't think it's reasonable to expect folks to find it on their own. We should do more to expose these.

Related

Tickets: #5120
Tickets: #5511
Tickets: #5609
Tickets: #6044
Tickets: #6046
Tickets: #6626

Discussion

1 2 > >> (Page 1 of 2)
  • Dave Brondsema

    Dave Brondsema - 2012-12-18

    It could even be the default view for a repo.

     
  • Dave Brondsema

    Dave Brondsema - 2012-12-18
    • milestone: limbo --> forge-backlog
     
  • Dave Brondsema

    Dave Brondsema - 2013-03-12
    • labels: support, p3 --> support, p3, 42cc
     
  • Dave Brondsema

    Dave Brondsema - 2013-03-12

    Let's make the default view use master/HEAD in the URL. And the sidebar links to branches should go to the branch (e.g. https://sourceforge.net/p/allura/git/ci/42cc_3027/tree/) instead of redirecting to a commit id. Same for tags.

    Since we don't use this form of URLs explicitly yet (although they seem to work fine), so there may be a few places where they don't work. Test to make sure all the views (history, commit, diff, merge requests, etc) work fine.

     
  • Igor Bondarenko

    Igor Bondarenko - 2013-03-13
    • status: open --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-03-13

    Created #297: [#5120] Change default urls for the repo (2cp)

     

    Related

    Tickets: #5120

  • Igor Bondarenko

    Igor Bondarenko - 2013-03-21
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-03-21

    Closed #297.

    Allura: je/42cc_5120

    ForgeHg: 42cc_5120 (just fixed related tests)

    Regarding branches with '/' in their names, seems like apache's AllowEncodedSlashes doesn't help with it. I've tried both On and NoDecode options (current apache version on sandboxes doesn't support the later, so I've upgraded apache). I've got 404 from apache for urls like ci/je%2F42cc/ with both of the above.

    Maybe I'm doing something wrong? Could you look at this, please?

    The second approach to fix it is to use some special character to determine where branch name ends and handle it in the TG controller(s) (see RefsController, that already does it).

     
  • Cory Johns

    Cory Johns - 2013-03-25
    • qa: Cory Johns
     
  • Cory Johns

    Cory Johns - 2013-03-25

    Putting the logic in url_for_commit makes all links to the head commits turn into the named links (e.g., in the History view). This makes it harder to get the link to a specific revision if it is the head of some branch.

    We really just want the branch links and default link from the app toolbar icon to use the named links, so instead of having the logic in url_for_commit, there should be a new url_for_symbolic and make BranchBrowser.index in the SCM implementations use that instead of url_for_commit, and make it work using the END_OF_REF_ESCAPE, as mentioned (will require change in CommitsController._lookup).

     
  • Cory Johns

    Cory Johns - 2013-03-25
    • status: code-review --> open
     
  • Cory Johns

    Cory Johns - 2013-03-25

    Upon further discussion regarding the END_OF_REF_ESCAPE, we're thinking we might want to look into getting the encoded slashes working, so don't worry about that part.

     
  • Igor Bondarenko

    Igor Bondarenko - 2013-03-27
    • status: open --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-03-27

    Created #307: [#5120] Fix visibility of "HEAD" urls (1cp)

     

    Related

    Tickets: #5120

  • Igor Bondarenko

    Igor Bondarenko - 2013-04-03
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-04-03

    Closed #307.

    Allura: je/42cc_5120
    ForgeHg: 42cc_5120

     
  • Cory Johns

    Cory Johns - 2013-04-04
    • status: code-review --> closed
    • milestone: forge-backlog --> forge-apr-05
     
  • Dave Brondsema

    Dave Brondsema - 2013-04-09
    • status: closed --> validation
     
  • Cory Johns

    Cory Johns - 2013-04-10

    allura:cj/5120
    forgehg:cj/5120

    Fixed handling of branches with / in the name. Also changed branch listing to only show first 10, as with tags.

     
  • Cory Johns

    Cory Johns - 2013-04-10
    • status: validation --> code-review
    • assigned_to: Cory Johns
    • Size: --> 1
    • Milestone: forge-apr-05 --> forge-apr-19
     
  • Cory Johns

    Cory Johns - 2013-04-10

    If the branches change is acceptable, could close out [#6044] as well.

     

    Related

    Tickets: #6044

  • Cory Johns

    Cory Johns - 2013-04-16
    • QA: Cory Johns --> nobody
     
  • Dave Brondsema

    Dave Brondsema - 2013-04-19
    • Milestone: forge-apr-19 --> forge-may-03
     
1 2 > >> (Page 1 of 2)

Log in to post a comment.