#6046 Make symbolic refs work for snapshots for Hg and SVN

v1.0.0
closed
nobody
General
Cory Johns
2015-08-20
2013-04-04
Cory Johns
No

Symbolic refs work in code snapshot links for git repositories, e.g. http://sourceforge.net/p/allura/git/ci/master/tarball, but not for Hg or SVN. They appear to partially work, in that a snapshot file is generated, but either the URL or the file name end up using the non-symbolic commit ID.

All three should probably be normalized to use the non-symbolic commit ID so that caching works properly (the code for "master" will change, so the cached allura-git-master.tar.gz file will be out of date), probably by making http://sourceforge.net/p/allura/git/ci/master/tarball redirect to the non-symbolic URL in case there is a push while waiting for the file to be complete.

Related

Tickets: #6046

Discussion

  • Cory Johns

    Cory Johns - 2013-04-04

    We'll also want to make sure it integrates with [#5120] so that the Download Snapshot link uses the symbolic ref when viewing using a symbolic ref so that it's discoverable.

     

    Related

    Tickets: #5120

  • Dave Brondsema

    Dave Brondsema - 2013-04-08
    • labels: --> code-snapshots
     
  • Dave Brondsema

    Dave Brondsema - 2013-04-11
    • labels: code-snapshots --> code-snapshots, 42cc
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-04-12

    Created #318: [#6046] Make symbolic refs work for snapshots for Hg and SVN (2cp)

     

    Related

    Tickets: #6046

  • Igor Bondarenko

    Igor Bondarenko - 2013-04-12
    • status: open --> in-progress
     
  • Cory Johns

    Cory Johns - 2013-04-12

    Please be aware of my updates in [#5120].

     

    Related

    Tickets: #5120

  • Igor Bondarenko

    Igor Bondarenko - 2013-04-24
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-04-24

    Closed #318. je/42cc_6046

     
  • Cory Johns

    Cory Johns - 2013-05-09
    • QA: Cory Johns
     
  • Cory Johns

    Cory Johns - 2013-05-09
    • status: code-review --> open
     
  • Cory Johns

    Cory Johns - 2013-05-09

    The Download Snapshot link is broken when viewing a subdirectory on a repo.

     
  • Igor Bondarenko

    Igor Bondarenko - 2013-05-10
    • status: open --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-05-10

    Created #350: [#6046] The Download Snapshot link is broken when viewing a subdirectory on a repo (1cp)

     

    Related

    Tickets: #6046

  • Cory Johns

    Cory Johns - 2013-05-10

    Keep in mind, in case it wasn't clear, the Download Snapshot button should still create a snapshot of the entire repo when used from a subdirectory; just the link is broken due to the way the request.path is parsed.

     
  • Dave Brondsema

    Dave Brondsema - 2013-05-10

    Or do we? For most SVN repos, you only want trunk/ or tags/x.y.z/ and not all tags & branches. Possibly an easy solution is to use the current dir for SVN at least.

     
  • Cory Johns

    Cory Johns - 2013-05-10

    Sorry, I do think it would be a good idea to support that feature, but I meant that I didn't intend to include it in the scope of this ticket.

     
  • Igor Bondarenko

    Igor Bondarenko - 2013-05-13
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-05-13

    Closed #350. je/42cc_6046

     
  • Igor Bondarenko

    Igor Bondarenko - 2013-05-13

    It was clear. Thanks for clarifications, though.

     
  • Cory Johns

    Cory Johns - 2013-05-23
    • status: code-review --> closed
    • Milestone: forge-backlog --> forge-may-31
     

Log in to post a comment.