#5561 Maximize view for wide code files

v1.0.1
closed
SCM
2015-08-20
2013-01-08
No

http://sourceforge.net/p/dclib/code/ci/b90ab60d8a18fc8616fb895b0d059c1cf07db3ce/tree/dlib/threads/thread_pool_extension_abstract.h#l69 requires horizontal scrolling which is extremely cumbersome (finding scrollbar at bottom of page) unless you have a mouse/touchpad to do horizontal scrolling directly.

It would be helpful to have a maximize button to make the source code take over the whole page. The button could be on all pages on a certain spot, but then also if overflow has occurred (can we detect this?) it could automatically appear as a button coming out of the right side of the code viewer, always present no matter which line you've scrolled to.

Diff views, particularly side-by-side need more room and should work with this too.

Related

Tickets: #5439
Tickets: #5744
Tickets: #6285
Tickets: #6852

Discussion

  • Cory Johns - 2013-09-30
    • status: open --> code-review
    • assigned_to: Cory Johns
    • Size: --> 1
    • Milestone: forge-backlog --> forge-oct-04
     
  • Cory Johns - 2013-09-30

    allura:cj/5561
    sftheme:cj/5561

     
  • Dave Brondsema

    Dave Brondsema - 2013-10-03

    Can we show this on diff views for individual files, and for individual files (no diff)? Looks good otherwise

     
  • Dave Brondsema

    Dave Brondsema - 2013-10-03
    • QA: Dave Brondsema
     
  • Cory Johns - 2013-10-03

    Updated and force-pushed (rebase) to:
    allura:cj/5561

     
  • Dave Brondsema

    Dave Brondsema - 2013-10-03

    But now we have some duplication. I can see this feature being added to more and more pages, so let's set it up for re-use now. The JS could be in a site-wide file, and the html could go in a macro.

     
  • Cory Johns - 2013-10-04

    allura:cj/5561 (force-pushed)
    sftheme:cj/5561

    Refactored to use macro. Also, fixed an issue with maximizing the diff browser, as well as the commit browser not working at all in OSS Allura theme.

     
  • Dave Brondsema

    Dave Brondsema - 2013-10-04
    • status: code-review --> closed
     

Log in to post a comment.