#6235 SVN snapshots should be aware of trunk/tags/branches

v1.0.0
closed
nobody
42cc (432)
General
Dave Brondsema
2015-08-20
2013-05-13
Dave Brondsema
No

Many SVN repos have a trunk/tags/branches/ directory structure, so a code snapshot of the whole repository has a lot of duplicated files and takes lot longer to build. Download snapshot links for SVN should be aware of this structure (which can occur at the top level, or nested down a level or more e.g. https://sourceforge.net/p/funambol/code/HEAD/tree/ox-connector/tags/) and only generate a snapshot of the specific branch, tag, or the trunk that the current page is part of. If the current page is not within a branches/ tags/ or trunk/ URL, then use the top-level trunk/ dir if it exists and if it doesn't, then use the whole repo. I think that logic will work well, of course adjust it if needed.

The resulting zip files will have to incorporate the repo path in their filenames, so that there can be saved zip files of the same SVN revision but different directories.

Related

Tickets: #5120
Tickets: #6070
Tickets: #6235

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-05-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,3 @@
-Many SVN repos have a trunk/tags/branches/ directory structure, so a code snapshot of the whole repository has a lot of duplicated files and takes lot longer to build.  Download snapshot links for SVN should be aware of this structure (which can occur at the top level, or nested down a level e.g. https://sourceforge.net/p/funambol/code/HEAD/tree/ox-connector/tags/) and only generate a snapshot of the specific branch, tag, or the trunk that the current page is part of.  If the current page is not within a branches/ tags/ or trunk/ URL, then use the top-level trunk/ dir if it exists and if it doesn't, then use the whole repo.  I think that logic will work well, of course adjust it if needed.
+Many SVN repos have a trunk/tags/branches/ directory structure, so a code snapshot of the whole repository has a lot of duplicated files and takes lot longer to build.  Download snapshot links for SVN should be aware of this structure (which can occur at the top level, or nested down a level or more e.g. https://sourceforge.net/p/funambol/code/HEAD/tree/ox-connector/tags/) and only generate a snapshot of the specific branch, tag, or the trunk that the current page is part of.  If the current page is not within a branches/ tags/ or trunk/ URL, then use the top-level trunk/ dir if it exists and if it doesn't, then use the whole repo.  I think that logic will work well, of course adjust it if needed.
+
+The resulting zip files will have to incorporate the repo path in their filenames, so that there can be saved zip files of the same SVN revision but different directories.
     

  • Igor Bondarenko - 2013-05-14

    Created #352: [#6235] SVN snapshots should be aware of trunk/tags/branches (3cp)

     

    Related

    Tickets: #6235

  • Igor Bondarenko - 2013-05-14
    • status: open --> in-progress
     

  • Igor Bondarenko - 2013-05-17

    Closed #352

    Allura: je/42cc_6235
    ForgeHg: 42cc_6235

     

  • Igor Bondarenko - 2013-05-17
    • status: in-progress --> code-review
     

  • Tim Van Steenburgh - 2013-05-23
    • QA: Tim Van Steenburgh
    • Milestone: forge-backlog --> forge-may-31
     

  • Tim Van Steenburgh - 2013-05-23
    • status: code-review --> in-progress
     

  • Tim Van Steenburgh - 2013-05-23

    This is looking good but I have a few suggestions:

    1. I'd like to see some unit tests for the new _path_to_root() method in svn.py
    2. The places where /tmp is hardcoded in the tests need to be changed to use g.tmpdir. See git show 760cf5 for examples.
    3. [pastebin:519e5bc81be1ce126eb12c0a] - I don't like this change because it presumes that Allura knows details of an individual tool's implementation. The path should be passed all the time, and each tool should decide whether to use it.
     

  • Igor Bondarenko - 2013-05-24

    Created #366: [#6235] SVN snapshots should be aware of trunk/tags/branches (followup to #352) (1cp)

     

    Related

    Tickets: #6235

  • Tim Van Steenburgh - 2013-05-24
    • QA: Tim Van Steenburgh --> nobody
     

  • Igor Bondarenko - 2013-05-29
    • status: in-progress --> code-review
     

  • Igor Bondarenko - 2013-05-29

    Closed #366.

    Allura: je/42cc_6235 (forced update)
    ForgeHg: 42cc_6235

     

  • Dave Brondsema

    Dave Brondsema - 2013-05-31
    • Milestone: forge-may-31 --> forge-jun-14
     

  • Dave Brondsema

    Dave Brondsema - 2013-05-31
    • QA: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2013-05-31
    • status: code-review --> closed
     

Log in to post a comment.