#6906 "Error 500: We're sorry but we weren't able to process this request." when replying to tracker item

v1.1.0
closed
sf-1 (616)
General
2015-08-20
2013-11-21
Anonymous
No

Originally created by: dcommander

I cannot add comments or reply to existing comments on tracker items in project libjpeg-turbo. Specifically, I was trying to reply to https://sourceforge.net/p/libjpeg-turbo/patches/54/. The site gives me "Error 500: We're sorry but we weren't able to process this request."

I have been able to successfully do this within the past week, so this is a new bug.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-11-22

    Error trace is:

    File '/var/local/allura/Allura/allura/controllers/discuss.py', line 322 in reply
      p = self.thread.add_post(parent_id=self.post._id, **kw)
    File '/var/local/allura/Allura/allura/model/discuss.py', line 234 in add_post
      p = self.post(**kw)
    File '/var/local/allura/Allura/allura/model/discuss.py', line 278 in post
      post.approve(file_info, notify=kw.get('notify', True))
    File '/var/local/allura/Allura/allura/model/discuss.py', line 639 in approve
      self.notify(file_info=file_info)
    File '/var/local/allura/Allura/allura/model/discuss.py', line 660 in notify
      file_info=file_info)
    File '/var/local/allura/Allura/allura/model/notification.py', line 108 in post
      n = cls._make_notification(artifact, topic, **kw)
    File '/var/local/allura/Allura/allura/model/notification.py', line 174 in _make_notification
      references=cls._references(artifact, post),
    File '/var/local/allura/Allura/allura/model/notification.py', line 245 in _references
      while post.parent_id:
    AttributeError: 'NoneType' object has no attribute 'parent_id'
    
     
  • Cory Johns

    Cory Johns - 2013-11-25
    • status: open --> in-progress
    • assigned_to: Cory Johns
     
  • Cory Johns

    Cory Johns - 2013-11-25
    • status: in-progress --> code-review
    • Size: --> 1
    • Milestone: limbo --> forge-nov-29
     
  • Cory Johns

    Cory Johns - 2013-11-25

    allura:cj/6906

    [#6328] changed the format and value for top-level comments of the In-Reply-To header that gets parsed and put into the parent_id field of the post.

    The code change will fix the format going forward and gracefully handle the ~4000 existing posts with the wrong format (they might not get threaded properly, but they won't block replies). We could run a mongo update to fix their format, but I'm not sure it's worth it since their notifications have already gone out and been threaded or not.

     

    Related

    Tickets: #6328

  • Tim Van Steenburgh

    • QA: Tim Van Steenburgh
     
  • Tim Van Steenburgh

    • status: code-review --> validation
     
  • Dave Brondsema

    Dave Brondsema - 2013-11-26
    • status: validation --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2013-11-26

    This should work now, please let us know if it does not.

     

Log in to post a comment.