#6328 Use In-Reply-To: and References: headers for outgoing ticket emails

v1.1.0
closed
nobody
42cc (432)
Mail
Cory Johns
2015-08-20
2013-06-04
Anonymous
No

Originally created by: nieder

Outgoing ticket emails should use the In-Reply-To: and References: headers so that recipient user agents can group messages from the same ticket together.

For example, e-mails from Canonical's Launchpad tracker use the Message-ID of the original post in the References: field of follow up posts. The same should happen with SF ticket e-mails. In case a user replies via e-mail or using the "Reply" button on the web interface, the Message-ID of the 'parent' message should be appended to the In-Reply-To: and References: headers.

Related

Tickets: #4804
Tickets: #6328
Tickets: #6906

Discussion

  • Anonymous - 2013-07-08

    Originally by: vampire0

    This is really important in my opinion.
    Currently it is not really possible to follow an issue by notification emails.
    In Gmail e. g. the Mails to one Ticket from the same sender are grouped together, but from different senders it is different Threads, so the messages are out of order because of the missing In-Reply-To/References headers and thus you do not read the messages in the correct order.

     

    Last edit: Anonymous 2015-08-11
  • Dave Brondsema

    Dave Brondsema - 2013-09-24
    • labels: --> 42cc
    • Milestone: limbo --> forge-backlog
     
  • Igor Bondarenko - 2013-09-25
    • status: open --> in-progress
     
  • Igor Bondarenko - 2013-09-25

    Created #448: [#6328] Use In-Reply-To: and References: headers for outgoing ticket emails (3cp)

     

    Related

    Tickets: #6328

  • Igor Bondarenko - 2013-10-23
    • status: in-progress --> code-review
     
  • Igor Bondarenko - 2013-10-23

    Closed #448. je/42cc_6328

     
  • Cory Johns - 2013-10-24
    • QA: Cory Johns
     
  • Cory Johns - 2013-10-24
    • status: code-review --> closed
    • Milestone: forge-backlog --> forge-nov-01
     
  • Dave Brondsema

    Dave Brondsema - 2013-10-28
    • status: closed --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2013-10-28

    This is working great in my opinion, except for a case of nested replies so I'm going to re-open it for that:

    If I hit "reply" on a comment and make a nested reply, the email has References and In-Reply-To headers that properly match the parent email. However, in Thunderbird, the message doesn't get included in that thread, it makes a new thread. I suggest reading up on how those headers should be, but IIRC one of the headers can have multiple values and we may need to include the original id in addition to the parent (and may even all intermediate message ids if you're in a very deep nested discussion)

     
  • Igor Bondarenko - 2013-10-29

    You're right. References header should contain message-ids of all of the parents. Gmail grouping working even if there only In-Reply-To, that's why I missed that.

    Created #465: [#6328] Fix notification email grouping for Thunderbird (followup:448) (1cp)

     

    Related

    Tickets: #6328

  • Igor Bondarenko - 2013-11-01
    • status: in-progress --> code-review
     
  • Igor Bondarenko - 2013-11-01

    I didn't reproduce Thunderbird behavior. I've tested on Thunderbird 24.0 and it grouped all messages properly. Anyway, I made changes to Reference header, test it yourself, please.

    Closed #465. Force-pushed je/42cc_6328

     
  • Dave Brondsema

    Dave Brondsema - 2013-11-01
    • Milestone: forge-nov-01 --> forge-nov-15
     
  • Cory Johns - 2013-11-01
    if isinstance(references, list):
        references = [u'<%s>' % r for r in references]
    else:
        references = [references]
    

    There seems to be a disagreement there as to whether the angle-brackets should be added. Additionally, I think paste.deploy.converters.aslist() could be used here to simplify that. Something like:

    references = [u'<%s>' % r for in aslist(references)]
    

    Can you please make that change, if it's correct, and add a test case to Allura/allura/tests/test_tasks:TestMailTasks for this change (there's one there for the Sender header that you could base it off of).

     
  • Cory Johns - 2013-11-01
    • status: code-review --> open
     
  • Igor Bondarenko - 2013-11-04
    • status: open --> in-progress
     
  • Igor Bondarenko - 2013-11-04

    Oops, somehow missed that :(

    Created #474: [#6328] Fix references handling (followup:465) (1cp)

     

    Related

    Tickets: #6328

  • Igor Bondarenko - 2013-11-04
    • status: in-progress --> code-review
     
  • Igor Bondarenko - 2013-11-04

    Closed #474.

       e755fdd..ee7ae2a  t474_references_fix -> je/42cc_6328
    
     
  • Cory Johns - 2013-11-04
    • status: code-review --> validation
     
  • Dave Brondsema

    Dave Brondsema - 2013-11-04
    • status: validation --> closed
     

Log in to post a comment.