Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, ccruz, deshani, and 11 others

#7826 Validate email format on /auth/forgotten_password

Milestone: v1.3.1

Status: closed

Owner: nobody

Labels: ux (103)

Component: General

Reviewer: Dave Brondsema

Updated: 2015-08-10

Created: 2015-02-04

Creator: Dave Brondsema

Private: No

The form at /auth/forgotten_password should validate the email address format. Currently you could put "afd3wrfes" as your email address and Allura will blindly go ahead and say "If the given email address is on record, a password reset email has been sent to the account's primary email address." even though obviously the email isn't even possible to be valid.

Discussion

Pranav Sharma - 2015-03-04

I want to fix it.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Igor Bondarenko - 2015-03-04
  
  Great! You can create a fork of Allura repository and then create a merge request when you done. Feel free to post any questions here.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pranav Sharma - 2015-04-09

I have edited 2 files for this feature to be added. Please help me how to create a merge request.

Last edit: Pranav Sharma 2015-04-09

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Igor Bondarenko - 2015-04-09
  
  Fork the main repo by pressing "Fork" button in the left sidebar at https://forge-allura.apache.org/p/allura/git
  
  git push your changes to your fork
  
  Create a merge request by pressing "Request Merge" (left sidebar on your fork's main page)
  
  Post a link to your merge request here, someone from the core team will review it
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Pranav Sharma - 2015-04-11
    
    Merge Request Link -
    https://forge-allura.apache.org/p/allura/git/merge-requests/22/
    
    Last edit: Pranav Sharma 2015-04-11
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    - Dave Brondsema - 2015-04-14
      
      Thanks Pranav! Great to see a new contribution like this. I've posted my feedback about the code changes on the merge request page.
      
      If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-04-24

I've merged the merge-requests. Thanks for the contribution, Pranav!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-04-24

status: open --> closed

Reviewer: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-08-10

Milestone: unreleased --> v1.3.1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.