#7826 Validate email format on /auth/forgotten_password

v1.3.1
closed
nobody
ux (103)
General
2015-08-10
2015-02-04
No

The form at /auth/forgotten_password should validate the email address format. Currently you could put "afd3wrfes" as your email address and Allura will blindly go ahead and say "If the given email address is on record, a password reset email has been sent to the account's primary email address." even though obviously the email isn't even possible to be valid.

Discussion

  • Pranav Sharma

    Pranav Sharma - 2015-03-04

    I want to fix it.

     
    • Igor Bondarenko

      Igor Bondarenko - 2015-03-04

      Great! You can create a fork of Allura repository and then create a merge request when you done. Feel free to post any questions here.

       
  • Pranav Sharma

    Pranav Sharma - 2015-04-09

    I have edited 2 files for this feature to be added. Please help me how to create a merge request.

     

    Last edit: Pranav Sharma 2015-04-09
    • Igor Bondarenko

      Igor Bondarenko - 2015-04-09
      • Fork the main repo by pressing "Fork" button in the left sidebar at https://forge-allura.apache.org/p/allura/git
      • git push your changes to your fork
      • Create a merge request by pressing "Request Merge" (left sidebar on your fork's main page)
      • Post a link to your merge request here, someone from the core team will review it
       
      • Pranav Sharma

        Pranav Sharma - 2015-04-11
         

        Last edit: Pranav Sharma 2015-04-11
        • Dave Brondsema

          Dave Brondsema - 2015-04-14

          Thanks Pranav! Great to see a new contribution like this. I've posted my feedback about the code changes on the merge request page.

           
  • Dave Brondsema

    Dave Brondsema - 2015-04-24

    I've merged the merge-requests. Thanks for the contribution, Pranav!

     
  • Dave Brondsema

    Dave Brondsema - 2015-04-24
    • status: open --> closed
    • Reviewer: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2015-08-10
    • Milestone: unreleased --> v1.3.1
     

Log in to post a comment.