This ticket ended up being extremely large and making these changes to Allura too:
_nav.json
param
Tickets: #7920
Tickets: #7921
Tickets: #7931
Tickets: #8034
Tickets: #8035
Tickets: #8045
Wiki: Goals
Looking at what you've pushed so far, here's some feedback on the code:
_nav.json
will have to accomodate.def mount_order
usingexcept AttributeError
seems to be a pretty rough way to know if its a subproject. Other things could potentially cause an AttributeError too. Is there a more precise way?AppConfig.__json__
you moved a line with_deinstrument
in it, but left the comment about that behindnavbar.css
andnavbar.es6.js
rat-excludes.txt
and confirm they are BSD/MIT/Apache licensedAnd UI items. (I know there's still a lot in progress)
Yes to all of this :)
Thanks for the great feedback!
Last edit: Heith Seewald 2015-10-09
Diff:
Diff:
Heith and I both contributed a lot to this huge branch, and reviewed each other's work.