#7921 Remove old tool configuration page

v1.4.0
closed
Igor Bondarenko
new-admin (8) sf-current (14) 42cc (432) sf-4 (350)
General
Dave Brondsema
2016-02-05
2015-07-10
Heith Seewald
No

After the new tool admin system is implemented, we should remove all traces of the old tools page.

A number of tests will have to be updated also, that use the tools page to manage tools.

Related

Tickets: #8004

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-12-18
    • labels: new-admin --> new-admin, sf-current
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,2 +1,3 @@
 After the new tool admin system is implemented, we should remove all traces of the old tools page.

+A number of tests will have to be updated also, that use the tools page to manage tools.
    • status: blocked --> open
     

  • Igor Bondarenko - 2016-01-12
    • labels: new-admin, sf-current --> new-admin, sf-current, 42cc
    • status: open --> in-progress
    • assigned_to: Igor Bondarenko
     

  • Dave Brondsema

    Dave Brondsema - 2016-01-13
    • labels: new-admin, sf-current, 42cc --> new-admin, sf-current, 42cc, sf-4
     

  • Dave Brondsema

    Dave Brondsema - 2016-01-15

    Changing some settings sends you to the old Tools page too. I think those would be better going back to the referer.

     

  • Igor Bondarenko - 2016-01-21
    • status: in-progress --> review
     

  • Igor Bondarenko - 2016-01-21

    Closed #887, #890. ib/7921

     

  • Heith Seewald - 2016-01-23
    • Reviewer: Heith Seewald
     

  • Heith Seewald - 2016-01-25
    • status: review --> in-progress
     

  • Heith Seewald - 2016-01-25

    Looking good -- there are just a few areas that might need one more look.

    1. Allura/allura/ext/user_profile/templates/sections/tools.html:27
    2. ForgeSVN/forgesvn/templates/svn/index.html:73
    3. AlluraTest/twill-tests/create_repo.twill:{29,45}
    4. Allura/allura/tests/functional/test_neighborhood.py:22 (unused re import added)
     

  • Denis Kotov - 2016-01-26

    How I can run twill tests?
    I try
    $ twill-sh --url=http://localhost:8080 twill-tests/create_repo.twill
    And as result I get an error

    EXCEPTION raised at line 24 of 'twill-tests/create_repo.twill'

     submit

    Error message: 'Invalid URL './do_login': No schema supplied. Perhaps you meant http://./do_login?'

     

    • Dave Brondsema

      Dave Brondsema - 2016-01-26

      The twill tests haven't been used in a years. Really they should just be deleted since they are so old and unused.

       

  • Denis Kotov - 2016-01-27

    We have removed

    {% block actions %}
    {% if user == c.user %}
        <a href="{{c.project.url()}}admin/tools">Add Tools</a>
    {% endif %}
{% endblock %}

    from Allura/allura/ext/user_profile/templates/sections/tools.html.
    But what can we use instead of this block? Or leave as is?

     

    • Heith Seewald - 2016-01-28

      I think just removing it like you did is good for now. Maybe we can revisit this when we work on the new “Add Project” workflow.

       

  • Denis Kotov - 2016-01-27
    • status: in-progress --> review
     

  • Dave Brondsema

    Dave Brondsema - 2016-02-05
    • status: review --> closed
    • Reviewer: Heith Seewald --> Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2016-04-11
    • Milestone: unreleased --> v1.4.0
     

Log in to post a comment.