#8004 Remove tool icons from project nav

v1.3.2
closed
General
Heith Seewald
2015-11-02
2015-10-16
No

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-10-19
    • labels: ux --> ux, sf-current
     
  • Dave Brondsema

    Dave Brondsema - 2015-10-19
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2015-10-19

    Any opinions on removing them from other places? The current tool admin page is planned to be removed in [#7921]. So that just leaves the Add Project page. If that's the only thing left, I'm thinking it should be removed from there too.

    And then should we clean out all references to tool icons in the code? I am currently thinking it might be best to leave it there, in case someone wants to make a theme that does use icons in the future.

     

    Related

    Tickets: #7921

    • Dave Brondsema

      Dave Brondsema - 2015-10-19

      The project admin landing page has them too. That page needs some updates and improvements anyway.

       
    • Dave Brondsema

      Dave Brondsema - 2015-10-19

      And the little icons when browse a list of projects, e.g. default neighborhood listing of projects

       
  • Heith Seewald

    Heith Seewald - 2015-10-19

    I agree that the landing page could use some updates... or maybe even replaced with contextual info. The landing page could be the meta page -- which could also help disambiguate the word meta in this context.

    The most useful part of the landing page is this section:

    Project Setup

    The first thing to do to setup your project is to create a solid description, so folks coming to your page can figure out what the project is all about. You'll then want to input information about the project, and we'll make sure all this relevant information gets added to the Allura project directory.*

    This may be more effective as some kind of closable notification (or contextual tooltip) right after you first create a project anyway.

    As for the “New Project” page -- The icons look natural here and I don’t think they detract from the page… but at the same time I don’t think they’re adding anything either.
    Removing the icons could work here.


    I’ve attached very rough idea of project page with/without icons to help visualize the difference.

     

    Last edit: Heith Seewald 2015-10-19
    • Dave Brondsema

      Dave Brondsema - 2015-10-20

      Yes, those are the kind of ideas I was thinking about for the project admin page.

      I also agree that the Add project page is nice with icons, but if icons themselves aren't great and aren't used anywhere else, makes sense to remove. I'll aim for something like without.png

      For the neighborhood list of projects, I am thinking the card view could be modified to show tool names instead of icons, but that would be just ugly. Might be best to just remove that "card" view and only do the "list" view of projects.

       
  • Dave Brondsema

    Dave Brondsema - 2015-10-22
    • labels: ux, sf-current --> ux, sf-current, sf-4
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2015-10-22

    db/8004

    I went ahead and removed the display_mode=grid default option from the [[projects]] macro since the card view would look pretty empty without the tool icons.

    Also some associated changes on SF repos sftheme, forge-classic

     
  • Heith Seewald

    Heith Seewald - 2015-10-22
    • Reviewer: Heith Seewald
     
  • Heith Seewald

    Heith Seewald - 2015-10-23

    Visually, I think this is very appealing. Nice work!

    Two quick questions:

    Is there something keeping us from removing this completely?

    allura/lib/macro.py
    
    272:     display_mode=None, grid_view_tools='',  # old & unused now
    287:     display_mode=None, grid_view_tools='',  # old & unused now
    

    2) Do you think this should be in the ini? Or we could just remove it completely.

    allura /templates/jinja_master/master.html:36
    {#  {% do g.register_css('/nf/tool_icon_css?' + g.build_key, compress=False) %}   If you need tool icons, use this #}
    
     
    • Dave Brondsema

      Dave Brondsema - 2015-10-23

      1) that's for backwards compatibility so that any existing macros that people have on their pages won't error out

      2) fixed in a new commit

       
  • Heith Seewald

    Heith Seewald - 2015-10-23

    Everything looks good. Merged.

     
  • Heith Seewald

    Heith Seewald - 2015-10-23
    • status: review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2015-11-02
    • labels: ux, sf-current, sf-4 --> ux, sf-4
     
  • Dave Brondsema

    Dave Brondsema - 2015-12-08
    • Milestone: unreleased --> v1.3.2
     

Log in to post a comment.