#7958 Clean up old project-level permission management page
wont-fix
nobody
General
nobody
2017-03-16
2015-08-10
No
A long time ago we made a new permissions page for projects, which combined group management and permission management. It is at the '/groups' url, but we never removed the old project permission management page at '/permissions'
I came across it recently because in a subproject we still link to /permissions and not /groups
We should update links, and remove the /permissions page for projects. (Take care that the /permissions pages for tools is not affected, it is still needed!)
I checked, the permissions page still exists.
I think the following files/code need to be deleted :
1.Allura/allura/ext/admin/templates/project_permissions.html
In ext/admin_main.py:
In class ProjectAdminController
2. self.permissions = PermissionsController()
This piece of code?
3.""" @without_trailing_slash
@expose('jinja:allura.ext.admin:templates/project_permissions.html')
def groups(self, **kw):
return dict()"""
4.Full class PermissionsController
Remove the relevant tests in Allura/allura/tests/functional/test_admin.py
Last edit: huzaifafaruqui 2017-03-07
The above mentioned solution and the corresponding merge request[#186] failed as the subproject uses /permissions page and forcing it to use /groups URL doesn't work. See this commit
Related
Tickets:
#186Removing
PermissionsControlleris correct. It looks like theproject_permissions.htmltemplate is used there and also in the "groups" URL which is still used. So that template should remain. You can test removing it to see what happens :) Thedef groupsmethod definitely needs to stay.If you haven't noticed yet, there are permissions at the project level, and then also within each app/tool, so make sure you test both areas.
Removing project_permissions.html page had no effect on "groups" URL, which uses project_groups.html template.
https://forge-allura.apache.org/p/allura/git/merge-requests/186/