Apache Allura™

Originally by: vampire0

This is really important in my opinion.
Currently it is not really possible to follow an issue by notification emails.
In Gmail e. g. the Mails to one Ticket from the same sender are grouped together, but from different senders it is different Threads, so the messages are out of order because of the missing In-Reply-To/References headers and thus you do not read the messages in the correct order.

• labels: --> 42cc
• Milestone: limbo --> forge-backlog

• status: open --> in-progress

Created #448: [#6328] Use In-Reply-To: and References: headers for outgoing ticket emails (3cp)

• status: in-progress --> code-review

Closed #448. je/42cc_6328

• QA: Cory Johns

• status: code-review --> closed
• Milestone: forge-backlog --> forge-nov-01

• status: closed --> in-progress

This is working great in my opinion, except for a case of nested replies so I'm going to re-open it for that:

If I hit "reply" on a comment and make a nested reply, the email has References and In-Reply-To headers that properly match the parent email. However, in Thunderbird, the message doesn't get included in that thread, it makes a new thread. I suggest reading up on how those headers should be, but IIRC one of the headers can have multiple values and we may need to include the original id in addition to the parent (and may even all intermediate message ids if you're in a very deep nested discussion)

You're right. References header should contain message-ids of all of the parents. Gmail grouping working even if there only In-Reply-To, that's why I missed that.

Created #465: [#6328] Fix notification email grouping for Thunderbird (followup:448) (1cp)

• status: in-progress --> code-review

I didn't reproduce Thunderbird behavior. I've tested on Thunderbird 24.0 and it grouped all messages properly. Anyway, I made changes to Reference header, test it yourself, please.

Closed #465. Force-pushed je/42cc_6328

• Milestone: forge-nov-01 --> forge-nov-15

if isinstance(references, list):
    references = [u'<%s>' % r for r in references]
else:
    references = [references]

There seems to be a disagreement there as to whether the angle-brackets should be added. Additionally, I think paste.deploy.converters.aslist() could be used here to simplify that. Something like:

references = [u'<%s>' % r for in aslist(references)]

Can you please make that change, if it's correct, and add a test case to Allura/allura/tests/test_tasks:TestMailTasks for this change (there's one there for the Sender header that you could base it off of).

• status: code-review --> open

• status: open --> in-progress

Oops, somehow missed that :(

Created #474: [#6328] Fix references handling (followup:465) (1cp)

• status: in-progress --> code-review

Closed #474.

   e755fdd..ee7ae2a  t474_references_fix -> je/42cc_6328

• status: code-review --> validation

• status: validation --> closed